Skip to content

Changed Binding to x:Bind in WrapLayoutSample DataTemplates #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avid29 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Changed Binding to x:Bind in WrapLayoutSample DataTemplates #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
417ee66
Changed Binding to x:Bind in WrapLayoutSample DataTemplates
Avid29 Jan 9, 2026
551e4ed
XAML Styles
Avid29 Jan 9, 2026
ea1a5f7
Merge branch 'main' into fix_WrapLayoutSample
Arlodotexe Feb 10, 2026
f3c3c52
Merge branch 'main' into fix_WrapLayoutSample
Avid29 Feb 23, 2026
15955c7
Merge branch 'main' into fix_WrapLayoutSample
Avid29 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions components/Primitives/samples/WrapLayoutSample.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
<Page x:Class="PrimitivesExperiment.Samples.WrapLayoutSample"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
Expand All @@ -10,31 +10,30 @@
xmlns:muxc="using:Microsoft.UI.Xaml.Controls"
Copy link
Copy Markdown

@Jay-o-Way Jay-o-Way Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Copy Markdown
Member Author

@Avid29 Avid29 Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is needed for WinUI 2 support where the ItemsRepeater depends on the Microsoft.UI.Xaml.Controls, but the default namespace is Windows.UI.Xaml.Controls.

mc:Ignorable="d">
<Page.Resources>
<DataTemplate x:Key="WrapTemplate">
<Border Width="{Binding Width}"
<DataTemplate x:Key="WrapTemplate"
x:DataType="local:ColorItem">
<Border Width="{x:Bind Width}"
Height="48"
CornerRadius="{StaticResource ControlCornerRadius}">
<Border.Background>
<SolidColorBrush Color="{Binding Color}" />
<SolidColorBrush Color="{x:Bind Color}" />
</Border.Background>
<TextBlock Margin="6,4,4,4"
FontSize="16"
Text="{Binding Index}" />
Text="{x:Bind Index}" />
Comment thread
Arlodotexe marked this conversation as resolved.
</Border>
</DataTemplate>
</Page.Resources>

<Grid>
<ScrollViewer x:Name="WrapScrollParent">
<muxc:ItemsRepeater x:Name="WrapRepeater"
ItemTemplate="{StaticResource WrapTemplate}"
ItemsSource="{x:Bind ColorsCollection, Mode=OneWay}">
<muxc:ItemsRepeater.Layout>
<controls:WrapLayout x:Name="Wrap"
HorizontalSpacing="{x:Bind HorizontalSpacing, Mode=OneWay}"
VerticalSpacing="{x:Bind VerticalSpacing, Mode=OneWay}" />
</muxc:ItemsRepeater.Layout>
</muxc:ItemsRepeater>
</ScrollViewer>
<muxc:ItemsRepeater x:Name="WrapRepeater"
Copy link
Copy Markdown
Member

@Arlodotexe Arlodotexe Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the ScrollViewer was removed. ItemsRepeater doesn't have a bullt-in ScrollViewer, we should either add it back or use an ItemsView instead, which uses an ItemsRepeater internally but acts more like a ListView than an ItemsControl.

ItemTemplate="{StaticResource WrapTemplate}"
ItemsSource="{x:Bind ColorsCollection, Mode=OneWay}">
<muxc:ItemsRepeater.Layout>
<controls:WrapLayout x:Name="Wrap"
HorizontalSpacing="{x:Bind HorizontalSpacing, Mode=OneWay}"
VerticalSpacing="{x:Bind VerticalSpacing, Mode=OneWay}" />
</muxc:ItemsRepeater.Layout>
</muxc:ItemsRepeater>
</Grid>
</Page>
8 changes: 7 additions & 1 deletion components/Primitives/samples/WrapLayoutSample.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ public WrapLayoutSample()
random = new Random(DateTime.Now.Millisecond);
for (int i = 0; i < random.Next(1000, 5000); i++)
{
var item = new ColorItem { Index = i, Width = random.Next(50, 250), Height = random.Next(50, 250), Color = Color.FromArgb(255, (byte)random.Next(0, 255), (byte)random.Next(0, 255), (byte)random.Next(0, 255)) };
var item = new ColorItem
{
Index = i,
Width = random.Next(50, 250),
Height = random.Next(50, 250),
Color = Color.FromArgb(255, (byte)random.Next(0, 255), (byte)random.Next(0, 255), (byte)random.Next(0, 255))
};
ColorsCollection.Add(item);
}
}
Expand Down
Loading