Add actions read permission to NuGet release job#470
Open
jfversluis wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request adjusts the GitHub Actions workflow for the NuGet release pipeline by granting the release job explicit permission to read GitHub Actions resources, which is required when job-level permissions are locked down and actions/download-artifact is used.
Changes:
- Added
actions: readto thereleasejob’s explicitpermissionsblock in.github/workflows/dotnet-build.ymlto supportactions/download-artifact.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/dotnet-build.yml | Adds actions: read permission to the NuGet release job to allow artifact download under restricted permissions. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release blocker
Merging this PR is mandatory before the next release. Without this change, NuGet trusted publishing will fail at the
NuGet/loginstep because noNUGET_USERenvironment secret will be present.Summary
actions: readto the NuGet.orgreleasejob permissions alongsideid-token: writeandcontents: read.jfversluis_MSFTforNuGet/logininstead of a hidden secret.${{ steps.login.outputs.NUGET_API_KEY }}; the username itself is public.actions/download-artifactrequiresactions: readwhen job permissions are explicitly restricted.Validation
git diff --checkreleasejob includesactions: read,id-token: write, andcontents: read.NuGet/loginusesuser: jfversluis_MSFTand no longer references${{ secrets.NUGET_USER }}.${{ steps.login.outputs.NUGET_API_KEY }}.