Fix build warnings treated as errors across the solution

[DavidGarton8]

When the project is first opened, several warnings appear across the solution, which is noisy and can be distracting with TreatWarningsAsErrors enabled. I wanted to clean up all of these warnings in one pass rather than open a series of small PRs, but I’m happy to split or adjust this if that would be preferred.

Changes

• Added missing XML documentation comments
• Removed a stray semicolon
• Fixed a nullability warning in tests
• Suppressed an intentional obsolete warning

PR Checklist

• Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
• Based off latest main branch of toolkit
• PR doesn't include merge commits (always rebase on top of our main, if needed)
• New integration
  • Docs are written
  • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Contains NO breaking changes
• Every new API (including internal ones) has full XML docs
• Code follows all style conventions

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1468

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1468"

[jmezach]

@aaronpowell It looks like the recently added integration codeowner workflow is failing here, but I'm not sure why. It's complaining about core being already defined, but I don't see it. Any ideas?

[DavidGarton8]

Core is already defined by GitHub script itself. I don't think you need to declare it again.

https://github.com/actions/github-script/blob/main/src/main.ts