Improve affected test selection for TypeScript AppHost files#1379
Open
aaronpowell wants to merge 1 commit into
Open
Improve affected test selection for TypeScript AppHost files#1379aaronpowell wants to merge 1 commit into
aaronpowell wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1379Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1379" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the affected-test selector so TypeScript AppHost example changes map to the relevant test projects instead of forcing the full integration test matrix.
Changes:
- Adds TypeScript AppHost path resolution for
examples/**/.AppHost.TypeScript/**. - Adds a fallback map from
TypeScriptAppHostTests.csmetadata to affected test projects. - Removes unused changed-project helper code.
Show a summary per file
| File | Description |
|---|---|
eng/testing/select-affected-tests.cs |
Adds TypeScript AppHost-to-test mapping logic and cleans up unused selection helpers. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: N/A
TypeScript AppHost example changes were triggering a full integration test matrix because
examples/...AppHost.TypeScript/apphost.mtsfiles were not mapped to a test project. This update makes test selection smarter so those changes select only affected tests.The selector now resolves TypeScript example apphost paths to their matching
.AppHostproject when possible and adds a fallback map built fromtests/**/TypeScriptAppHostTests.csargument metadata (exampleNameandappHostProject). That fallback ensures TypeScript fixture changes still map to the correct test project even when there is no direct project-reference edge.PR Checklist
Other information
No behavioral changes to test execution itself; this only narrows test selection for TypeScript AppHost example changes.