Deprecate CommunityToolkit Bun hosting integration in favor of core Aspire.Hosting.JavaScript#1376
Merged
Merged
Conversation
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Deprecate Bun integration and update documentation
Deprecate CommunityToolkit Bun hosting integration in favor of core May 28, 2026
Aspire.Hosting.JavaScript
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1376Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1376" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deprecates the Toolkit Bun hosting integration in favor of Aspire’s core JavaScript hosting support, while keeping the current API available during the migration window.
Changes:
- Adds obsolete annotations to Bun hosting extension methods and API metadata.
- Updates NuGet/package README/root README deprecation messaging.
- Suppresses obsolete warnings in Bun examples/tests and adds reflection coverage for deprecation attributes.
Show a summary per file
| File | Description |
|---|---|
src/CommunityToolkit.Aspire.Hosting.Bun/BunAppExtensions.cs |
Adds deprecation message and obsolete annotations to Bun extension methods. |
src/CommunityToolkit.Aspire.Hosting.Bun/api/CommunityToolkit.Aspire.Hosting.Bun.cs |
Mirrors obsolete annotations in generated API metadata. |
src/CommunityToolkit.Aspire.Hosting.Bun/CommunityToolkit.Aspire.Hosting.Bun.csproj |
Updates package tags and description to signal deprecation. |
src/CommunityToolkit.Aspire.Hosting.Bun/README.md |
Adds deprecation notice and migration examples. |
README.md |
Marks the Bun integration as deprecated in the root integration table. |
examples/bun/CommunityToolkit.Aspire.Hosting.Bun.AppHost/Program.cs |
Suppresses obsolete warnings for the example AppHost. |
tests/CommunityToolkit.Aspire.Hosting.Bun.Tests/AddBunAppTests.cs |
Suppresses obsolete warnings and adds deprecation attribute assertions. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 2
Comment on lines
+57
to
58
| [Obsolete(BunDeprecationMessage)] | ||
| public static IResourceBuilder<BunAppResource> WithBunPackageInstallation(this IResourceBuilder<BunAppResource> resource, Action<IResourceBuilder<BunInstallerResource>>? configureInstaller = null) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
aaronpowell
approved these changes
Jun 1, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aspire now provides first-class Bun support via
Aspire.Hosting.JavaScript(AddBunApp), so the Toolkit Bun integration should guide users to migrate off the Toolkit package. This PR deprecates the Toolkit surface and updates package/docs with explicit migration guidance.API deprecation
[Obsolete]with a migration message:AddBunApp(...)WithBunPackageInstallation(...)Package deprecation signaling
CommunityToolkit.Aspire.Hosting.Bun:deprecatedpackage tagAspire.Hosting.JavaScript) and planned removal.Docs and migration guidance
builder.addBunApp(...)).Compatibility posture