Adding two properties for "process has first/last instant"#862
Open
giacomodecolle wants to merge 4 commits intoCommonCoreOntology:developfrom
Open
Adding two properties for "process has first/last instant"#862giacomodecolle wants to merge 4 commits intoCommonCoreOntology:developfrom
giacomodecolle wants to merge 4 commits intoCommonCoreOntology:developfrom
Conversation
Contributor
|
@giacomodecolle Did you see the guidance here by chance: https://github.com/CommonCoreOntology/CommonCoreOntologies/blob/develop/documentation/contributing/registering%20IRIs.md There is an IRI registry branch here: https://github.com/CommonCoreOntology/CommonCoreOntologies/tree/iri-registry-branch I agree that shrink-wrapped occupation should be functional. |
Author
|
Updated the axioms and IRIs, do they go in a separate PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #605
I would appreciate some guidance on how to mint IRIs, I wasn't able to find any in the repo. Similarly to see if this is following other CCO contribution guidelines that I might not be aware of.
Regarding the two properties, I would also like to change the definition to says something along the lines of "x exactly occupies_temporal_region z", that is, to say that the temporal extent of process x is exactly the temporal extent of temporal region z.
It also sounds reasonable to me that this relation should be functional.