Conversation
…nd billing (BE-16743) A new release gets a new deployment and the old one keeps billing. up already listed those deployments in the JSON supersedes array, but the terminal said nothing. It now warns once per deployment with the stop command to run.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthrough
ChangesDeploy billing warning
Suggested reviewers: Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This change helps users identify older deployments that may still incur billing, with tested warnings and stop commands; no merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Swarmhost agentic reviewAn internal review is in progress. Detailed evaluations are not published on public repositories. Updated by Swarmhost's agentic review process. |
comfy deploy upon a new release creates a new deployment and leaves the old one running and billing.upalready lists those deployments in the JSONsupersedesarray, but the terminal said nothing.Now
upprints one warning per older deployment still holding compute, with the command that stops it:Under
--jsonthe warning goes to stderr, asup's other warnings do; the envelope is unchanged.Tests:
test_up_warns_that_an_older_release_deployment_is_still_billing,test_a_person_at_the_terminal_sees_the_billing_warning,test_up_with_nothing_else_running_prints_no_billing_warningintests/comfy_cli/command/test_deploy_up.py. Each warning test fails with the fix reverted.Linear: BE-16743