Skip to content

fix(deploy): up says an older release's deployment is still running and billing (BE-16743) - #930

Open
vqt123 wants to merge 2 commits into
mainfrom
vinh/be-16743-up-warns-superseded
Open

vqt123 wants to merge 2 commits into
mainfrom
vinh/be-16743-up-warns-superseded

Conversation

@vqt123

@vqt123 vqt123 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

comfy deploy up on a new release creates a new deployment and leaves the old one running and billing. up already lists those deployments in the JSON supersedes array, but the terminal said nothing.

Now up prints one warning per older deployment still holding compute, with the command that stops it:

Deployment dep-old (release v3, ready) is still running and billing.
Hint: run `comfy deploy stop --deployment dep-old` if you no longer need it

Under --json the warning goes to stderr, as up's other warnings do; the envelope is unchanged.

Tests: test_up_warns_that_an_older_release_deployment_is_still_billing, test_a_person_at_the_terminal_sees_the_billing_warning, test_up_with_nothing_else_running_prints_no_billing_warning in tests/comfy_cli/command/test_deploy_up.py. Each warning test fails with the fix reverted.

Linear: BE-16743

…nd billing (BE-16743)

A new release gets a new deployment and the old one keeps billing. up already
listed those deployments in the JSON supersedes array, but the terminal said
nothing. It now warns once per deployment with the stop command to run.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0d9d0bd3-9e7f-4410-8795-bc2653433c60

📥 Commits

Reviewing files that changed from the base of the PR and between 64026d2 and 3ee1f97.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • comfy_cli/command/deploy_up.py
  • comfy_cli/skills/comfy-deploy/SKILL.md
  • tests/comfy_cli/command/test_deploy_up.py

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

comfy deploy up now warns when superseded deployments remain running and billing. JSON mode sends warnings to stderr. Human-readable mode sends them to stdout. Documentation, changelog, and tests cover the behavior.

Changes

Deploy billing warning

Layer / File(s) Summary
Render superseded deployment warnings
comfy_cli/command/deploy_up.py
_render_result reports each superseded deployment, including its ID, release, status, and the comfy deploy stop --deployment <id> command.
Document and validate warning behavior
tests/comfy_cli/command/test_deploy_up.py, comfy_cli/skills/comfy-deploy/SKILL.md, CHANGELOG.md
Tests cover JSON warnings, human-readable warnings, and the case with no superseded deployments. Documentation and the changelog describe the output behavior.

Suggested reviewers: guill

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 3ee1f

This change helps users identify older deployments that may still incur billing, with tested warnings and stop commands; no merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from guill September 22, 2026 14:33
@comfy-greenlight-bot

Copy link
Copy Markdown

Swarmhost agentic review

An internal review is in progress. Detailed evaluations are not published on public repositories.

Updated by Swarmhost's agentic review process.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants