fix(layout): reserve image preview height - #925
christian-byrne wants to merge 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughImage-upload widgets now add preview height to node size estimates. New and persisted nodes pass detected preview counts into layout sizing. Regression coverage verifies populated image-loader nodes reserve space and do not overlap. ChangesImage Preview Layout
Priority: ⬇️ Low Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to Image-upload nodes now reserve space for rendered previews, preventing row overlap while preserving existing sizing behavior. The change is ready to merge. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Summary
LoadImage→SaveImagerows with a no-overlap regressionThe PM-1607/PM-1608 artifact shows the
SaveImagecolumn remaining clean while each populatedLoadImagepreview grows into the row below it. The previous model counted the image combo and upload button but not the DOM preview host added bycreateImageHost, so it persisted a roughly 102px body for a loader that renders at roughly 292px once populated.Validation
uv run pytest tests/comfy_cli/test_layout.py tests/comfy_cli/test_layout_quality.py tests/comfy_cli/test_persisted_node_size.py tests/comfy_cli/command/test_workflow_edit.py -q— 235 passeduv run ruff check comfy_cli/layout.py comfy_cli/workflow_ops.py tests/comfy_cli/test_persisted_node_size.pyuv run ruff format --check comfy_cli/layout.py comfy_cli/workflow_ops.py tests/comfy_cli/test_persisted_node_size.pyLinear: PM-1607