fix(generate): use advanced image saver - #922
christian-byrne wants to merge 1 commit into
Conversation
Closes PM-1100.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughImage workflow generation now emits ChangesImage output emission
Suggested reviewers: Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to Image workflows now emit the advanced PNG-saving node with preserved filename prefixes, with matching workflow and round-trip coverage. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Summary
SaveImageAdvancedfor partner image workflows instead of legacySaveImageThis makes workflows built through the in-app agent's
generate_workflowprimitive use the org's canonical Save Image (Advanced) node.Validation
uv run pytest tests/comfy_cli/command/generate/test_emit.py tests/comfy_cli/command/generate/test_emit_ops.py— 64 passeduv run ruff check .uv run ruff format --check .Closes PM-1100.