Skip to content

fix(generate): use advanced image saver - #922

Open
christian-byrne wants to merge 1 commit into
mainfrom
christian-byrne/pm-1100-save-image-advanced
Open

christian-byrne wants to merge 1 commit into
mainfrom
christian-byrne/pm-1100-save-image-advanced

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

  • emit SaveImageAdvanced for partner image workflows instead of legacy SaveImage
  • set the canonical PNG format explicitly alongside the existing filename prefix
  • preserve op-materialization and API-to-frontend round-trip coverage for the advanced node

This makes workflows built through the in-app agent's generate_workflow primitive use the org's canonical Save Image (Advanced) node.

Validation

  • uv run pytest tests/comfy_cli/command/generate/test_emit.py tests/comfy_cli/command/generate/test_emit_ops.py — 64 passed
  • uv run ruff check .
  • uv run ruff format --check .
  • full suite: 7,817 passed, 32 skipped; 46 unrelated baseline/environment failures in run preflight fixtures, rich TTY rendering, and filesystem umask semantics

Closes PM-1100.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: aa0c7642-337a-4a1f-b246-2df60fd1ecbc

📥 Commits

Reviewing files that changed from the base of the PR and between 64026d2 and 1ae1c54.

📒 Files selected for processing (3)
  • comfy_cli/command/generate/emit.py
  • tests/comfy_cli/command/generate/test_emit.py
  • tests/comfy_cli/command/generate/test_emit_ops.py

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Image workflow generation now emits SaveImageAdvanced with explicit image, filename prefix, and PNG format inputs. Tests update workflow, operation-generation, deprecation, and round-trip expectations.

Changes

Image output emission

Layer / File(s) Summary
Advanced output generation
comfy_cli/command/generate/emit.py
Documentation and image workflow generation now use SaveImageAdvanced. The generated node receives the image link, filename prefix, and PNG format.
Advanced output validation
tests/comfy_cli/command/generate/test_emit.py, tests/comfy_cli/command/generate/test_emit_ops.py
Tests now validate SaveImageAdvanced, its format options and IMAGE output, filename prefixes, deprecation handling, and round-trip output links.

Suggested reviewers: annehe9

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 1ae1c

Image workflows now emit the advanced PNG-saving node with preserved filename prefixes, with matching workflow and round-trip coverage. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from annehe9 September 22, 2026 09:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant