Migrate GoogleSearchTest from Selenium/TestNG to Playwright TypeScript - #17
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
Migrate GoogleSearchTest from Selenium/TestNG to Playwright TypeScript#17devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the single legacy test
GoogleSearchTest(Selenium + TestNG + POM + WebDriverManager) to a modern Playwright TS spec, as a self-containede2e-playwright/project. No Java, Maven, or TestNG file is touched — the legacy suite stays exactly as it is, so the two stacks live side by side.The whole legacy path —
BaseTestdriver bootstrap,GooglePagePOM,@FindBy(name = "q"), implicit waits,Assert.assertTrue(title.contains("abc"))— collapses into one spec, since Playwright's auto-waiting and web-first assertions replace the explicit driver/wait/report scaffolding:Two things worth calling out:
[name="q"]rather thaninput[name=q]: Google now renders the search box as a<textarea name="q">, so the legacy@FindBy(name = "q")semantics are preserved only by not asserting the tag.@playwright/testis pinned to an exact1.62.1rather than an older release, to avoid the browser-download advisory (GHSA-7mvr-c777-76hp) fixed in playwright 1.55.1.npm auditreports 0 vulnerabilities..github/workflows/playwright-google.ymlruns onpull_request(plusworkflow_dispatch), doesnpm ci+npx playwright install --with-deps chromiumine2e-playwright, and runs onlytests/google-search.spec.ts, uploading the HTML report as an artifact on failure. CI on this PR is the verification. Locally the spec passes headlessly (1 passed).Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/4270397d66274348a699e9f896fb9e26
Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/f46eebc578904c8fbce42f04bb0b1898
Requested by: @sumitshatwara