cowork: scan fails loudly when no config files load (silent-green guard) - #46
Draft
Coding-Dev-Tools wants to merge 2 commits into
Draft
cowork: scan fails loudly when no config files load (silent-green guard)#46Coding-Dev-Tools wants to merge 2 commits into
Coding-Dev-Tools wants to merge 2 commits into
Conversation
…nt-green guard) - exit 1 if zero config files loaded across all environment dirs - exit 1 if baseline env loaded no keys (empty-baseline diff would flag everything) - +5 regression tests in TestScanEmptyGuards; suite 148 passed, ruff clean
🤖 Automated Code Review✅ Ruff Lint — No issues
|
…ype drift Python's == treats True == 1, so a config change like 'debug: true -> debug: 1' silently compared as no drift. _values_differ() now flags cross-type changes (bool vs number) while same-type comparisons are unchanged. +7 regression tests in TestTypeSensitiveComparison; suite 155 passed, ruff clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a silent-failure trap in
configdrift scan: if every configured environment directory was missing or empty, the CLI printed warnings and exited 0 reporting 'no drift' — a false green for CI gating.Changes:
TestScanEmptyGuards); suite: 148 passed; ruff clean.