Harden site link resolution for GitHub Pages#4
Merged
OgeonX-Ai merged 2 commits intoJan 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
docs/root or from subpages underdocs/pages/on GitHub Pages.index.htmlvariants.Description
docs/*markdown files,docs/pages/*HTML pages,docs/assets/style.css,docs/assets/app.js, CI and GitHub templates) to provide a browsable static site and canonical docs.docs/assets/app.jsto introducegetBasePath()and replace the previous simple resolver withresolveHref(targetPath)that trims trailing slashes, strips/index.html, and handles/pages/segments to compute a stable base path.buildNav()andsetupSearch()) use the newresolveHref()so links resolve correctly from both the site root and subpages.index.htmland per-page HTML underdocs/pages/to validate the behavior.Testing
python -m http.server 8000and verifiedhttp://127.0.0.1:8000/index.htmlserved correctly.artifacts/docs-site-index-fixed.png, confirming rendered navigation..github/workflows/ci.yml) was added but was not executed as part of this change.Codex Task