Use default branch instead of use a specific version to avoid Node.js deprecations in the workflows#959
Open
MRK2009 wants to merge 10 commits intoCodenameCrew:internal-mergefrom
Open
Use default branch instead of use a specific version to avoid Node.js deprecations in the workflows#959MRK2009 wants to merge 10 commits intoCodenameCrew:internal-mergefrom
MRK2009 wants to merge 10 commits intoCodenameCrew:internal-mergefrom
Conversation
Contributor
Author
|
Wait let me test it out on the main branch first, before let this merged |
Contributor
Author
|
Yep, it does work. |
Contributor
Author
|
I'm still seeing Node.js version deprecations somewhere else |
MRK2009
changed the title
github-scripts and cache to the latest in the workflows
MRK2009
changed the title
MRK2009
changed the title
Contributor
Author
|
I think I'm done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot to update those, because I checked in the main branch and it does affect on both of them due to Node.js version deprecation. even though they were disabled for now in the internal merge branch.