Skip to content

fix: add alt attrs#2859

Open
Soare-Robert-Daniel wants to merge 5 commits into
developmentfrom
fix/alt-attr
Open

fix: add alt attrs#2859
Soare-Robert-Daniel wants to merge 5 commits into
developmentfrom
fix/alt-attr

Conversation

@Soare-Robert-Daniel

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Closes #2619

Summary

Add missing image properties for EU law.

Screenshots


Test instructions

Block Slug What to test E2E Manual
Icon List Item themeisle-blocks/icon-list-item Image icon → alt field. Frontend img always has alt (set or empty). Old post: no recovery → resave → alt="" Yes: frontend, decorative, inspector, migration ML prefill, clear alt via inspector
Icon List themeisle-blocks/icon-list Default library = Image → parent alt; new items inherit unless overridden Yes: inheritance + override Parent alt via Icons panel UI, ML prefill
Timeline Item themeisle-blocks/timeline-item Image icon → alt field. Frontend .o-timeline-icon img Yes: frontend, decorative, inspector, migration ML prefill
Image Slider themeisle-blocks/slider Per-slide alt in Images panel. No title on img. Old content: resave drops title Yes: alt, no title, inspector, legacy resave Reorder → alt stays with image
Flip Card themeisle-blocks/flip Front = Image → alt below preview Yes: frontend Inspector edit
Product Review themeisle-blocks/review Product image alt in inspector; check frontend (PHP) Yes
Stripe Checkout themeisle-blocks/stripe-checkout Product img alt = product name. Needs Stripe + product image Yes
About Author (deprecated) themeisle-blocks/about-author Avatar alt = author name Yes
Posts Grid themeisle-blocks/posts-grid No change — smoke: featured img alt (ML → post title fallback) Smoke only

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jun 10, 2026
@pirate-bot

pirate-bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 178.24 KB 178.24 KB 0 B (0.00%)
Blocks 1.5 MB 1.5 MB 4.83 KB (0.32%)
CSS 7.87 KB 7.87 KB 0 B (0.00%)
Dashboard 108.48 KB 108.48 KB 0 B (0.00%)
Onboarding 68.14 KB 68.14 KB 0 B (0.00%)
Export Import 4.7 KB 4.7 KB 0 B (0.00%)
Pro 320.08 KB 320.07 KB -3 B (-0.00%)

@pirate-bot

pirate-bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Plugin build for 0299fba is ready 🛎️!

@pirate-bot

pirate-bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

E2E Tests

Playwright Test Status: See serial and parallel matrix jobs

Performance Results serverResponse: {"q25":385.8,"q50":425.55,"q75":428.3,"cnt":10}, firstPaint: {"q25":498.2,"q50":524.95,"q75":652.8,"cnt":10}, domContentLoaded: {"q25":3313.7,"q50":3361.3,"q75":3409.9,"cnt":10}, loaded: {"q25":3314.1,"q50":3361.75,"q75":3410.5,"cnt":10}, firstContentfulPaint: {"q25":8725.9,"q50":8854.55,"q75":8873.3,"cnt":10}, firstBlock: {"q25":13370.2,"q50":13391.9,"q75":13484.2,"cnt":10}, type: {"q25":20.26,"q50":22.32,"q75":22.8,"cnt":10}, typeWithoutInspector: {"q25":17.73,"q50":19.67,"q75":20.12,"cnt":10}, typeWithTopToolbar: {"q25":26.8,"q50":27.71,"q75":29.42,"cnt":10}, typeContainer: {"q25":12.77,"q50":13.36,"q75":16.43,"cnt":10}, focus: {"q25":99.24,"q50":102.57,"q75":109.08,"cnt":10}, inserterOpen: {"q25":36.13,"q50":36.7,"q75":36.9,"cnt":10}, inserterSearch: {"q25":12.31,"q50":12.46,"q75":12.72,"cnt":10}, inserterHover: {"q25":4.89,"q50":5,"q75":5.1,"cnt":20}, loadPatterns: {"q25":1446.95,"q50":1462.04,"q75":1486.18,"cnt":10}, listViewOpen: {"q25":205.25,"q50":210.58,"q75":217.04,"cnt":10}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants