refactor(Video): Remove SCSS from Video#3390
Draft
aresnik11 wants to merge 8 commits into
Draft
Conversation
|
View your CI Pipeline Execution ↗ for commit 573e728 ☁️ Nx Cloud last updated this comment at |
|
Update vidstack-vendor.css to use the webpack ~ module resolution prefix, which tells webpack to resolve imports from node_modules. This ensures the CSS imports are correctly resolved in both Storybook and consumer builds like Codecademy. Fixes module resolution error: "Can't resolve './@vidstack/react/..." when Codecademy's webpack processes the CSS file from the gamut dist output. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Collaborator
|
📬 Published Alpha Packages:
|
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://6a4fd7383cfc8d33e48d4a7b--gamut-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Video component was the last consumer of a standalone SCSS file (
vds_base_theme.scss) for styling the Vidstack player. This PR removes that SCSS dependency, splitting its contents into two more idiomatic sources:vidstack-vendor.css— the three third-party Vidstack@imports (default theme + video/audio layouts), imported as plain CSS.styles.ts— our custom Vidstack overrides (YouTube overlay, control buttons, sliders, tooltips, keyframes), converted to an Emotioncsstemplate (vdsBaseThemeStyles) and applied through the existingVariableProviderstyled component.This aligns the Video component with the rest of Gamut's Emotion-based styling and removes the last SCSS file from the package.
PR Checklist
Testing instructions
Verify the Vidstack player looks and behaves identically to
main— the goal is a no-visual-change refactor.iframe.vds-youtubeheight override) both before and after playback starts.yarn nx build gamut) and confirmvidstack-vendor.cssis present indist/Video/.Testing Scenarios
Story 1: Default (Internal MP4 Video)
Player Renders
Playback Controls
Volume Control
Seek Bar
Fullscreen
Player Title
Story 2: Video With Tracks and Thumbnails (HLS + Captions)
Placeholder Image
Text Tracks - Subtitles
Chapter Markers
Thumbnails
HLS Streaming
Video Duration
Buffering
Story 3: YouTube With Captions
YouTube uses VidstackPlayer instead of ReactVideoPlayer when captions are present.
Story 4: Multiple Video Sources
Test fallback behavior when multiple video formats provided.
Story 5: YouTube without embed
Tests the edge case where
showPlayerEmbedprop isfalse, forcingVidstackPlayerfor YouTube/Vimeo.Regression Testing Checklist
Youtube and Vimeo stories without captions use ReactVideoPlayer (React-Player wrapper) which was not modified
PR Links and Envs