Skip to content

Allow underscore aliases for spawned agent IDs#568

Merged
jahooma merged 1 commit intomainfrom
jahooma/spawn-agent-id-aliases
Apr 30, 2026
Merged

Allow underscore aliases for spawned agent IDs#568
jahooma merged 1 commit intomainfrom
jahooma/spawn-agent-id-aliases

Conversation

@jahooma
Copy link
Copy Markdown
Contributor

@jahooma jahooma commented Apr 30, 2026

Summary

  • Accept underscores as aliases for hyphens in spawned agent IDs during lookup and permission matching.
  • Resolve canonical agent IDs for spawn validation without changing publisher or version syntax.
  • Add regression coverage for simple and published underscored agent_type values.

Testing

  • bun test packages/agent-runtime/src/tests/spawn-agents-permissions.test.ts
  • bun test packages/agent-runtime/src/tests/prompts-schema-handling.test.ts
  • bun run typecheck (common)
  • bun run typecheck (packages/agent-runtime)
  • bun run test (packages/agent-runtime)

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@jahooma jahooma merged commit e5a93b2 into main Apr 30, 2026
34 checks passed
@jahooma jahooma deleted the jahooma/spawn-agent-id-aliases branch April 30, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant