Skip to content

Glasgow | 26-July-SDC | Mirabelle Morah | Sprint 1 | Individual Shell Tools#551

Open
mirabellemorah wants to merge 11 commits into
CodeYourFuture:mainfrom
mirabellemorah:sprint-1-individual-shell-tools
Open

Glasgow | 26-July-SDC | Mirabelle Morah | Sprint 1 | Individual Shell Tools#551
mirabellemorah wants to merge 11 commits into
CodeYourFuture:mainfrom
mirabellemorah:sprint-1-individual-shell-tools

Conversation

@mirabellemorah

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have done all the excercises including the stretch versions, completing all shell commands as instructed, from ls to awk, cat, grep, sed and wc.

Questions

Sed feels a litle confusing now to me, are there any commonly used sed commands that you would recommend often remembering?

@mirabellemorah

Copy link
Copy Markdown
Author
Screenshot 2026-07-05 at 13 34 05 I currently don't seem to have the option to add labels right now to show that I need a review

@mirabellemorah mirabellemorah added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 6, 2026
@LonMcGregor LonMcGregor added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Results of test:
Failed awk/script-06-stretch.sh, please check
Failed sed/script-04.sh, please check
Failed sed/script-05.sh, please check
You passed 28/31 tasks.

@mirabellemorah

Copy link
Copy Markdown
Author

Results of test: Failed awk/script-06-stretch.sh, please check Failed sed/script-04.sh, please check Failed sed/script-05.sh, please check You passed 28/31 tasks.

Just had a review of my work.

  • sed/script-04.sh: my script seems to change 'we'll' to 'we will' correctly. Not very sure what the error is or how to troubleshoot this further.
  • sed/script-05.sh: my initial version was wrong and I used -e flag initially, now corrected to -E
  • awk/script-06-stretch.sh: I see why this 'failed' I had actually stretched by writing

awk '{sum += $3} END {print "the total first score is " sum}' scores-table.txt
which outputted the total first score is 54

So it was a correct output. But the instructions say that "Your output should be exactly the number 54." So now I've adjusted this to: awk '{sum += $3} END {print sum}' scores-table.txt
which now outputs exactly 54 in the console.

@LonMcGregor

Copy link
Copy Markdown
Contributor

Good work - your solution for sed 4 is correct, my test is wrong,sorry about that. This task is complete now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 7, 2026
@mirabellemorah

mirabellemorah commented Jul 7, 2026

Copy link
Copy Markdown
Author

Good work - your solution for sed 4 is correct, my test is wrong,sorry about that. This task is complete now

🙏🏽 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants