London | 26-ITP-May | Chun Yan Wong | Sprint 1 | CourseWork#1466
Open
cywong-dev wants to merge 18 commits into
Open
London | 26-ITP-May | Chun Yan Wong | Sprint 1 | CourseWork#1466cywong-dev wants to merge 18 commits into
cywong-dev wants to merge 18 commits into
Conversation
Added comment explaining the increment operation on the count variable.
Initialize dir and ext variables to extract directory and file extension from filePath.
[ChunYanWong] Added comment explaining num as a random integer.
Updated last4Digits assignment to correctly extract the last 4 digits of cardNumber.
Added comments to clarify variable declarations, function calls, and expressions related to movie length.
Added comments to explain the purpose of each step in the code.
Clarify the effects and return values of alert and prompt functions.
Added syntax help for console.log and console.
This comment has been minimized.
This comment has been minimized.
cywong-dev
added
the
Needs Review
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
cywong-dev
changed the title
This comment has been minimized.
This comment has been minimized.
cywong-dev
changed the title
cywong-dev
added
Needs Review
cjyuan
reviewed
Jul 7, 2026
cjyuan
added
Reviewed
cywong-dev
added
Needs Review
cjyuan
added
Reviewed
Contributor
|
Could you also format the checkboxes (in the self checklist) so that they looks like this:
instead of like this: [X] I have tested my changes For more info, see; https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-tasklists |
Author
Yes, done |
Convert cardNumber to string before slicing to ensure proper extraction of last 4 digits.
cywong-dev
added
Needs Review
cjyuan
reviewed
Jul 11, 2026
| // There is no -4 starting position and hence it will not work | ||
|
|
||
| const last4Digits = cardNumber.slice(cardNumber.length - 4) | ||
| const last4Digits = cardNumber.toString().slice(cardNumber.toString().length - 4) |
Contributor
There was a problem hiding this comment.
.slice() accepts negative index. .slice(-4) would be enough in this example
| // Create a variable to store the ext part of the variable | ||
|
|
||
| const dir = filePath.substring(0, url.lastIndexOf("/") + 1);; | ||
| const dir = filePath.substring(0, filePath.lastIndexOf("/") + 1);; |
Contributor
There was a problem hiding this comment.
I think it should not contain a trailing / for file directory
Have you checked if the value assigned to dir meets your expectation?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Complete the coursework for sprint 1 in the module Structuring and testing data