Cape Town | 25-ITP-May | Asanda Dunn | Sprint 3 | Sprint-3/2-practice-tdd/#1446
Open
asandagwala wants to merge 1 commit into
Open
Cape Town | 25-ITP-May | Asanda Dunn | Sprint 3 | Sprint-3/2-practice-tdd/#1446asandagwala wants to merge 1 commit into
asandagwala wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
asandagwala
added
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
asandagwala
changed the title
This comment has been minimized.
This comment has been minimized.
asandagwala
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
asandagwala
force-pushed
the
coursework/sprint-3-practice-tdd
branch
from
7a76aec to
74ecc4a
Compare
asandagwala
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
asandagwala
force-pushed
the
coursework/sprint-3-practice-tdd
branch
from
74ecc4a to
4e088d1
Compare
asandagwala
added
the
Needs Review
LonMcGregor
reviewed
Jul 8, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, these tasks are mostly complete, just one very minor remark from me
| let lastDigit = num % 10; | ||
| let lastTwoDigits = num % 100; | ||
| if (lastTwoDigits === 11 || lastTwoDigits === 12 || lastTwoDigits === 13) { | ||
| return `${num}th`; |
There was a problem hiding this comment.
Did you remember to run your IDE's formmatter here?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Module: Structure and testing data Sprint 3 work