-
-
Notifications
You must be signed in to change notification settings - Fork 389
London | ITP-26-May | Tomislav Dukez | Sprint 3 | Practice TDD #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomdu3
wants to merge
6
commits into
CodeYourFuture:main
Choose a base branch
from
tomdu3:coursework/sprint-3/2-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
966e522
add occurences count test and function
tomdu3 4699d42
add repeat string tests and function
tomdu3 1379d50
add get ordinal number tests and function
tomdu3 d86c3ed
fix remove redundant condition
tomdu3 602f4d6
fix formatting
tomdu3 1d5374d
fix my own stupidity - read the instructions
tomdu3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| return stringOfCharacters.split("").filter((char) => char === findCharacter) | ||
| .length; | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,24 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| // check if the input is not a number, not an integer, or if it's negative | ||
| if (typeof num !== "number" || !Number.isInteger(num) || num < 0) { | ||
| throw new Error("Invalid input: number must be a non-negative integer"); | ||
|
tomdu3 marked this conversation as resolved.
|
||
| } | ||
|
|
||
| if (num % 100 >= 11 && num % 100 <= 13) { | ||
| // check for numbers ending with 11, 12, or 13 | ||
| return num + "th"; | ||
| } else if (num % 10 === 1) { | ||
| // check for numbers ending with 1 (but not 11) | ||
| return num + "st"; | ||
| } else if (num % 10 === 2) { | ||
| // check for numbers ending with 2 (but not 12) | ||
| return num + "nd"; | ||
| } else if (num % 10 === 3) { | ||
| // check for numbers ending with 3 (but not 13) | ||
| return num + "rd"; | ||
| } | ||
| // For all other numbers, append "th" | ||
| return num + "th"; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,11 @@ | ||
| function repeatStr() { | ||
| function repeatStr(stringOfCharacters, count) { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| if (count === 0) { | ||
| return ""; | ||
| } else if (count > 0) { | ||
| return repeatStr(stringOfCharacters, count - 1) + stringOfCharacters; | ||
| } | ||
| throw Error("Invalid input: count must be a non-negative integer"); | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.