Skip to content

London | 26-ITP-May | Chun Yan Wong | Sprint 1 | Form Controls#1316

Open
cywong-dev wants to merge 7 commits into
CodeYourFuture:mainfrom
cywong-dev:staging-branch
Open

London | 26-ITP-May | Chun Yan Wong | Sprint 1 | Form Controls#1316
cywong-dev wants to merge 7 commits into
CodeYourFuture:mainfrom
cywong-dev:staging-branch

Conversation

@cywong-dev
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Display the form for the requirement with validation and display required

Questions

Nil

@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 365c0bf
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a0dc24d72a4d60008485fab
😎 Deploy Preview https://deploy-preview-1316--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@cywong-dev cywong-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@cywong-dev cywong-dev changed the title London | ITP-May-2026 | Chun Yan Wong | Sprint1 | OnBoarding - Form-Controls London | 26-ITP-May | Chun Yan Wong | Sprint 1 | Form Controls May 19, 2026
@cywong-dev cywong-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@cywong-dev cywong-dev added the Module-Onboarding The name of the module. label May 19, 2026
@Luro91 Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 20, 2026
Comment thread Form-Controls/index.html
@@ -1,27 +1,101 @@
<!DOCTYPE html>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The w3c validator is showing an error. How can you fix it?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the code to fix the error

Comment thread Form-Controls/index.html Outdated
Comment thread Form-Controls/index.html Outdated

<div>
<label for="customer-name">Customer's name : </label>
<input id="customer-name" name="customer-name" type="text" required pattern=".*\S.*\S.*"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on validating the user input

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment thread Form-Controls/index.html Outdated
Comment thread Form-Controls/index.html Outdated
@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 20, 2026
@cywong-dev cywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 20, 2026
@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants