London | 26-ITP-May | Tomislav Dukez | Sprint 1 | Form Controls#1312
Open
tomdu3 wants to merge 6 commits into
Open
London | 26-ITP-May | Tomislav Dukez | Sprint 1 | Form Controls#1312tomdu3 wants to merge 6 commits into
tomdu3 wants to merge 6 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tomdu3
added
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 20, 2026
Comment on lines
+21
to
+22
| <input minlength="3" type="text" id="name" name="name" pattern="^(?!\s*$).{3,}$" | ||
| title="Please enter at least 3 characters, not just spaces" required> |
There was a problem hiding this comment.
The requirements are at least 2 charcaters not 3
I must collect this data and ensure it contains at least two non-space characters.
Author
There was a problem hiding this comment.
Oh, my bad. Sorry. I was always using 3 chars min. Thanks.
Luro91
added
Reviewed
tomdu3
added
Needs Review
Luro91
reviewed
May 21, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done. The code works as expected
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
The PR contains changes in
/Form-Controls/index.htmlfile.Acceptance Criteria
HTML