Manchester | 26-ITP-May | John Robinson | Sprint 1 | Form Controls#1301
Open
JohnRob-jnr wants to merge 2 commits into
Open
Manchester | 26-ITP-May | John Robinson | Sprint 1 | Form Controls#1301JohnRob-jnr wants to merge 2 commits into
JohnRob-jnr wants to merge 2 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
JohnRob-jnr
changed the title
JohnRob-jnr
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 20, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
How can you ensure a lighthouse score of 100?
Comment on lines
16
to
+17
| <form> | ||
| <!-- write your html here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| <form class="order-form"> |
There was a problem hiding this comment.
I see 2 errors when I paste the code in the w3 validator: https://validator.w3.org/nu/#textarea
How can you fix them?
| this will also help you fill in your PR message later--> | ||
| </form> | ||
| <form class="order-form"> | ||
| <h2>T Shirt Order Form</h2> |
There was a problem hiding this comment.
The formatting standard for HTML elements is to use indentation on children elements. This makes it easier to understand the structure. How can you ensure consistent formatting in your code automatically?
| <!-- Name Field --> | ||
| <div class="form-group"> | ||
| <label for="name">Full Name</label> | ||
| <input type="text" id="name" name="name" placeholder="John Robinson" required> |
There was a problem hiding this comment.
How can you ensure that the input requires 2 characters?
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Created a form for T Shirts & have added CSS for styling that page
Questions