Skip to content

Birmingham | MAY 2026 | Ogbemi Mene | Sprint 1 | Form control #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meneogbemi42-bit wants to merge 4 commits into
base: main
Choose a base branch
from
+111 −25
Open

Birmingham | MAY 2026 | Ogbemi Mene | Sprint 1 | Form control #1294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc89d28
my form excesis
May 16, 2026
2f98a7b
my form working
May 16, 2026
c17d258
Change page title to 'T-shirt sales'
meneogbemi42-bit May 16, 2026
ad6aa94
Add email input and fix label formatting
meneogbemi42-bit May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions Form-Controls/Untitled-1.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@

body {
background-color: #7a8f88;
display: flex;
justify-content: center;
align-items: center;
height: 100vh;
margin: 0;
}

form {
background: #9b7a7a;
padding: 2rem;
border-radius: 8px;
box-shadow: 0 4px 15px rgba(0, 0, 0, 0.1);
width: 100%;
max-width: 400px;
}

form div {
margin-bottom: 1.5rem;
display: flex;
flex-direction: column;
}
label {
font-weight: bold;
font-size: 0.85rem;
margin-bottom: 0.5rem;
color: #333;
text-transform: uppercase;
}

input[type="text"],
input[type="email"],
select {
padding: 10px;
border: 1px solid #817575;
border-radius: 4px;
font-size: 1rem;
outline: none;
transition: border-color 0.3s;
}

input:focus,
select:focus {
border-color: #007bff;
}

button {
width: 100%;
padding: 12px;
background-color: #28a745;
color: white;
border: none;
border-radius: 4px;
font-size: 1.1rem;
cursor: pointer;
transition: background-color 0.3s;
}

button:hover {
background-color: #218838;
}
73 changes: 48 additions & 25 deletions Form-Controls/index.html
View file
Open in desktop
Copy link
Copy Markdown

@Luro91 Luro91 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 3 errors when checking the file in the w3 validator. How can you fix them?

Original file line number Diff line number Diff line change
@@ -1,27 +1,50 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
</footer>
</body>
</html>
<head>

<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>T-shirt sales</title>
<link rel="stylesheet" href="Untitled-1.css">
Copy link
Copy Markdown

@Luro91 Luro91 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else could you use as file name for the stylesheet to adhere more to standard naming?

</head>

<body>
Copy link
Copy Markdown

@Luro91 Luro91 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the body end?

<form action="T-shirt.html" method="GET">

<div>
<label for="name">NAME</label>
<input type="text" name="name" id="name" placeholder="name" value="name" required>
Copy link
Copy Markdown

@Luro91 Luro91 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can you ensure that the name has at least 2 characters?

</div>

<div>

<label for="email">EMAIL</label>
<input type="email" name="email" id="email" placeholder="email" value="email" required>
</div>

<div>

<label for="colour">colour of T-shirt</label>
<select name="colour" id="colour">
<option value="red">red</option>
<option value="blue">blue</option>
<option value="green">green</option>
</select>
</div>

<div>

<label for="size">size of T-shirt</label>

<select name="size" id="size" required>
Copy link
Copy Markdown

@Luro91 Luro91 May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The XS option is missing here

<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</div>

<button>Submit</button>


Loading