Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | New Feature: Rebloom - New by HassanOHOsman · Pull Request #262 · CodeYourFuture/Module-Legacy-Code

HassanOHOsman · 2026-08-20T13:35:00Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Questions

I just could not display the reblooms on my logged in user's timelines. I've spent a few days on it but to no avail.

illicitonion

This generally looks good, but a few thoughts, as well as not needing a reblooms table:

Right now when you show a rebloom it doesn't look like a rebloom - it looks like a new bloom by the reblooming user - how could you indicate that it's a rebloom (ideally showing what user it's a rebloom from)?
I think there's a caching issue that means when you rebloom something, your own profile timeline doesn't get invalidated, so if you do a rebloom then go to your own profile it doesn't show up until you refresh

illicitonion · 2026-08-21T08:22:03Z

    UNIQUE(hashtag, bloom_id)
 );
+
+CREATE TABLE reblooms (


You shouldn't need a separate table for reblooms - you have all the information you need in the blooms table with original_bloom_id, but may need to do some joins to get the data out

I've solved this now.

… later

…l error

…he main file

… to be exact)

2. add a test content for th erebloom counter

HassanOHOsman · 2026-08-21T21:40:43Z

Not the best... still needs some work. however, the caching issue is now resolved as far as I could tell from my end. Let me know if I still need to change or do anything. Thank you!

illicitonion

Generally looks good, but a few questions and still a few references to the reblooms table

illicitonion · 2026-08-24T09:10:07Z

+    with db_cursor() as cur:
+        cur.execute(
+            """
+            SELECT COALESCE(original_bloom_id, id)


Why do you need this COALESCE? When would the original_bloom_id not be present as an id for some row?

my understand is that since I've discarded the re-bloom table, and when i rebloom i need to figure out the original/root id for it. Hence the use of COALESCE(original_bloom_id, id).

illicitonion · 2026-08-24T09:11:01Z

+
+        cur.execute(
+            """
+            INSERT INTO reblooms (


I thought you deleted this table?

Yes, I did indeed, perhaps missed to get rid of all references to it.

illicitonion · 2026-08-24T09:11:20Z

+                blooms.original_bloom_id,
+                (
+                    SELECT COUNT(*)
+                    FROM reblooms


This table no longer exists?

Yes, I must've missed to remove all reference somehow. That's done now anyway.

illicitonion · 2026-08-24T09:12:01Z

+                blooms.original_bloom_id,
+                (
+                    SELECT COUNT(*)
+                    FROM reblooms


…refernce to rebloom table

…_for_user) to count from blooms instead of reblooms

…oom, who did it and when

…is a rebloom

rebloom now shows original author

…ter UI

2) Make rebloomed blooms show on end-user's - sample _ timeline

HassanOHOsman · 2026-08-25T10:05:13Z

This generally looks good, but a few thoughts, as well as not needing a reblooms table:

Right now when you show a rebloom it doesn't look like a rebloom - it looks like a new bloom by the reblooming user - how could you indicate that it's a rebloom (ideally showing what user it's a rebloom from)?

I think there's a caching issue that means when you rebloom something, your own profile timeline doesn't get invalidated, so if you do a rebloom then go to your own profile it doesn't show up until you refresh

RE:

A small banner appears above the post saying "🔁 Rebloomed by sample" so it is now clear in the UI both who originally bloomed it, and who re-bloomed it.
All re-bloomed blooms now show in sample's timeline without refreshing the page.

Please review and let me know if you still want me to do anything else. Thank you Daniel!

illicitonion · 2026-08-26T13:24:23Z

Looks good, well done!

github-project-automation Bot added this to Purple Forest Kanban Aug 20, 2026

github-project-automation Bot moved this to Backlog in Purple Forest Kanban Aug 20, 2026

HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Legacy-Code The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Aug 20, 2026

HassanOHOsman changed the title ~~Feature/re bloom~~ Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 1 | New Feature: Rebloom - New Aug 20, 2026

illicitonion reviewed Aug 21, 2026

View reviewed changes

illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 21, 2026

HassanOHOsman closed this Aug 21, 2026

HassanOHOsman force-pushed the feature/re-bloom branch from d42592a to b2dcd10 Compare August 21, 2026 15:28

github-project-automation Bot moved this from Backlog to Done in Purple Forest Kanban Aug 21, 2026

HassanOHOsman added 17 commits August 21, 2026 17:48

Add original_bloom_id to the blooms table to help us with the rebloom…

d9ed15b

… later

update the bloom class

48db6f4

Create rebloom function

397bca1

update rebloom function

320d5c6

update get_bloom function

df2ce91

add the missing comma inside the blooms table to avoid the syntactica…

532e6b3

…l error

update get_blooms_for_user function

62f68ec

update get_bloom func

64efa89

add an endpoint for reblooming

05ad727

import rebloom handler function endpoint and add a router for it in t…

db8601c

…he main file

setup the api.mjs for the rebloom endpoint

02f3358

Update the html structure (template tag with "bloom-form-template" id…

e0d739b

… to be exact)

update create bloom

fadd3e1

update bloom.mjs

7280198

update html to include span tag with the current rebloom count

d0f4bb3

Update the rebloom btn event listner to incoude count for reblooms

2207ba9

add rebloom_count field to my Bloom class

79bebde

HassanOHOsman reopened this Aug 21, 2026

github-project-automation Bot moved this from Done to Backlog in Purple Forest Kanban Aug 21, 2026

HassanOHOsman added 2 commits August 21, 2026 22:04

fix rebloom count persistence

6282c0d

1. update add_bloom function

8e9fdf8

2. add a test content for th erebloom counter

HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 21, 2026

illicitonion reviewed Aug 24, 2026

View reviewed changes

HassanOHOsman added 7 commits August 24, 2026 16:15

re-write rebloom function to use only bloom table and remove the old …

6d6ea81

…refernce to rebloom table

update the rebloom_count subqueries (in both get_bloom and get_blooms…

44b8c03

…_for_user) to count from blooms instead of reblooms

Update create bloom to include logic about whether the post is a rebl…

5d5687f

…oom, who did it and when

Update createBloom to include what logic to display incase the poast …

fd6089b

…is a rebloom

UI now displays the clearly the original bloom from a rebloomed bloom.

f7053c5

rebloom now shows original author

reposition the div tag containing the rebloomed bloom details for bet…

2b47907

…ter UI

1)fix broken other_profile endpoint

f5dd88c

2) Make rebloomed blooms show on end-user's - sample _ timeline

HassanOHOsman requested a review from illicitonion August 25, 2026 10:07

illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 26, 2026

Uh oh!

Uh oh!

Conversation

HassanOHOsman commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Questions

Uh oh!

illicitonion left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman commented Aug 21, 2026

Uh oh!

illicitonion left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman commented Aug 25, 2026

Uh oh!

illicitonion commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HassanOHOsman commented Aug 20, 2026 •

edited

Loading