Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions csharp-basic-topics/YieldBreakInCSharp/Tests/Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.12.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="3.1.2">
<PackageReference Include="coverlet.collector" Version="10.1.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
52 changes: 45 additions & 7 deletions csharp-basic-topics/YieldBreakInCSharp/Tests/UtilityTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,60 @@ namespace Tests;
public class UtilityTests
{
[Fact]
public void GenerateRandomYears_WhenCalled_GenerateRandomYears()
public void GenerateRandomYears_WhenCalled_StopsAtTheFirstLeapYear()
{
// Act
var years = Utility.GenerateRandomYears();
var years = Utility.GenerateRandomYears().ToList();

// Assert
Assert.NotEmpty(years);
Assert.True(DateTime.IsLeapYear(years[^1]));
Assert.All(years.SkipLast(1), year => Assert.False(DateTime.IsLeapYear(year)));
}

[Fact]
public void GenerateRandomYearsWithBreak_WhenCalled_GenerateRandomYears()
public void GenerateRandomYearsWithUnreachableCode_WhenCalled_SkipsTheLineAfterTheLoop()
{
// Act
var years = Utility.GenerateRandomYearsWithBreak();
var output = CaptureConsole(() => Utility.GenerateRandomYearsWithUnreachableCode().ToList());

// Assert
Assert.NotEmpty(years);
Assert.DoesNotContain("executed successfully", output);
}
}

[Fact]
public void GenerateRandomYearsWithBreak_WhenCalled_RunsTheLineAfterTheLoop()
{
// Act
var output = CaptureConsole(() => Utility.GenerateRandomYearsWithBreak().ToList());

// Assert
Assert.Contains("executed successfully", output);
}

[Fact]
public void GenerateRandomYearsWithCleanup_WhenCalled_RunsTheFinallyBlock()
{
// Act
var output = CaptureConsole(() => Utility.GenerateRandomYearsWithCleanup().ToList());

// Assert
Assert.Contains("The finally block ran.", output);
}

private static string CaptureConsole(Action action)
{
var original = Console.Out;
using var writer = new StringWriter();
Console.SetOut(writer);
try
{
action();
}
finally
{
Console.SetOut(original);
}

return writer.ToString();
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using YieldBreakInCSharp;

foreach (int year in Utility.GenerateRandomYearsWithBreak())
foreach (int year in Utility.GenerateRandomYears())
{
Console.WriteLine(year);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,39 +2,78 @@

public static class Utility
{
private static readonly Random random = new();

public static IEnumerable<int> GenerateRandomYears()
{
int year;
while (true)
{
year = random.Next(1900, 2023);
year = Random.Shared.Next(1900, 2023);
yield return year;

if (year % 4 == 0)
if (DateTime.IsLeapYear(year))
{
Console.WriteLine($"{Environment.NewLine}Encountered Leap Year:{year}");
yield break;
}
}
}

public static IEnumerable<int> GenerateRandomYearsWithUnreachableCode()
{
int year;
while (true)
{
year = Random.Shared.Next(1900, 2023);
yield return year;

if (DateTime.IsLeapYear(year))
{
Console.WriteLine($"{Environment.NewLine}Encountered Leap Year:{year}");
yield break;
}
}

Console.WriteLine("GenerateRandomYears() method executed successfully.");

Check warning on line 36 in csharp-basic-topics/YieldBreakInCSharp/YieldBreakInCSharp/Utility.cs

View workflow job for this annotation

GitHub Actions / Build & test (csharp-basic-topics/YieldBreakInCSharp)

Unreachable code detected

Check warning on line 36 in csharp-basic-topics/YieldBreakInCSharp/YieldBreakInCSharp/Utility.cs

View workflow job for this annotation

GitHub Actions / Build & test (csharp-basic-topics/YieldBreakInCSharp)

Unreachable code detected
}

public static IEnumerable<int> GenerateRandomYearsWithBreak()
{
int year;
while (true)
{
year = random.Next(1900, 2023);
year = Random.Shared.Next(1900, 2023);
yield return year;

if (year % 4 == 0)
if (DateTime.IsLeapYear(year))
{
Console.WriteLine($"{Environment.NewLine}Encountered Leap Year:{year}");
break;
}
}

Console.WriteLine("GenerateRandomYears method executed successfully.");
Console.WriteLine("GenerateRandomYears() method executed successfully.");
}

public static IEnumerable<int> GenerateRandomYearsWithCleanup()
{
try
{
int year;
while (true)
{
year = Random.Shared.Next(1900, 2023);
yield return year;

if (DateTime.IsLeapYear(year))
{
Console.WriteLine($"{Environment.NewLine}Encountered Leap Year:{year}");
yield break;
}
}
}
finally
{
Console.WriteLine("The finally block ran.");
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net11.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
Loading