fix: report catalog embedding latency in milliseconds - #5
Open
ivanmilevtues wants to merge 1 commit into
Open
ivanmilevtues wants to merge 1 commit into
ivanmilevtues wants to merge 1 commit into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a081b5-9435-7555-a03c-caf44e0d0dbf Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CodeBoarding reviewStatus: 1 changed component See the full change in CodeBoarding. graph LR
n_Ordering["Ordering"]
n_ClientApp["ClientApp"]
n_Webhooks["Webhooks"]
n_Identity["Identity"]
n_WebApp["WebApp"]
n_EventBus["EventBus"]
n_js["js"]
n_Loose_files_in_src_WebApp["Loose files in src.WebApp"]
n_Ordering -- "calls" --> n_Webhooks
n_Ordering -- "calls" --> n_EventBus
n_ClientApp -- "calls" --> n_Webhooks
n_Webhooks -- "calls" --> n_ClientApp
n_WebApp -- "calls" --> n_Webhooks
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_Ordering modified;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Replaces #2, recreated from the latest CodeBoarding/eShop main so this PR includes the current CodeBoarding workflows and committed analysis baseline.
Both CatalogAI trace messages name their structured field ElapsedMilliseconds but supplied seconds. Preserve the original fix: use TotalMilliseconds and the matching ms suffix for single and batch embedding generation. Embedding behavior is unchanged.
The old workflow-input commit is already on main and is not duplicated. This is no longer a baseline-free cold-start exercise.
Validation