Skip to content

fix: report catalog embedding latency in milliseconds - #5

Open
ivanmilevtues wants to merge 1 commit into
mainfrom
fix/catalog-embedding-log-units-latest-main
Open

ivanmilevtues wants to merge 1 commit into
mainfrom
fix/catalog-embedding-log-units-latest-main

Conversation

@ivanmilevtues

Copy link
Copy Markdown
Member

Purpose

Replaces #2, recreated from the latest CodeBoarding/eShop main so this PR includes the current CodeBoarding workflows and committed analysis baseline.

Both CatalogAI trace messages name their structured field ElapsedMilliseconds but supplied seconds. Preserve the original fix: use TotalMilliseconds and the matching ms suffix for single and batch embedding generation. Embedding behavior is unchanged.

The old workflow-input commit is already on main and is not duplicated. This is no longer a baseline-free cold-start exercise.

Validation

  • Confirmed the current fork main is an ancestor of this branch.
  • Confirmed CatalogAI.cs matches the original PR exactly.
  • git diff --check passed.
  • Local dotnet build was attempted with restore, but failed with duplicate assembly attribute errors in EventBus and eShop.ServiceDefaults; compilation is not verified.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T00:15:22.308803Z 258568a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

CodeBoarding review

Status: 1 changed component

See the full change in CodeBoarding.

graph LR
    n_Ordering["Ordering"]
    n_ClientApp["ClientApp"]
    n_Webhooks["Webhooks"]
    n_Identity["Identity"]
    n_WebApp["WebApp"]
    n_EventBus["EventBus"]
    n_js["js"]
    n_Loose_files_in_src_WebApp["Loose files in src.WebApp"]
    n_Ordering -- "calls" --> n_Webhooks
    n_Ordering -- "calls" --> n_EventBus
    n_ClientApp -- "calls" --> n_Webhooks
    n_Webhooks -- "calls" --> n_ClientApp
    n_WebApp -- "calls" --> n_Webhooks
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
    class n_Ordering modified;
Loading

download artifacts · run 35937470640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants