fix: make the no-proxy editor link clickable (https listing), drop install link#12
Merged
Merged
Conversation
…link GitHub's comment sanitizer strips custom vscode:/cursor: URI schemes, so the editor deep link rendered as dead bold text, not a link. Point the no-proxy editor link at the extension's https listing (VS Code Marketplace, Cursor via Open VSX), which GitHub keeps clickable, and drop the now-redundant 'Get the extension' line. The proxy path (cta_base_url set) is unchanged — it already uses https and can deep-link via redirect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The no-proxy editor link used a
vscode:/cursor:deep link, but GitHub's comment sanitizer strips custom URI schemes — confirmed on PR #365's rendered HTML, whereOpen in VS Code →came back as<strong>, not<a>. Onlyhttp(s)/mailtosurvive.Fix: point the no-proxy editor link at the extension's https listing (Marketplace for VS Code, Open VSX for Cursor) — clickable on GitHub — and drop the redundant
Get the extensionline. The proxy path (cta_base_urlset) is unchanged; it already uses https and deep-links via redirect.44 tests pass.