feat: link CTA to the extension when no click proxy is set#11
Merged
Conversation
The editor/extension CTA was gated on cta_base_url, so with no proxy (the default) PR comments showed only the warning banner — no link to open the architecture in the editor or install the extension. Now the links always render: through the proxy when cta_base_url is set, else straight to the editor deep link (vscode/cursor:extension/Codeboarding.codeboarding) and the Marketplace listing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the editor/extension CTA only appeared when
cta_base_urlwas set, so the default (no proxy — what the dogfood uses) showed only the warning banner, with no link to open in the editor or install the extension.Now the links always render:
<vscode|cursor>:extension/Codeboarding.codeboarding+ the VS Code Marketplace listing.Editor inference (.vscode/.cursor, default VS Code) and the⚠️ health banner are unchanged. Tests updated.