Add weather extension with API integration#5
Open
chrisdedman wants to merge 17 commits into
Open
Conversation
Contributor
chrisdedman
commented
Apr 13, 2026
chrisdedman
commented
- Added weather extension (ported from Grace Bot and adapted for Ada Bot).
- Required to get our own ADA_OPENWEATHER_API_KEY var env.
- Also ran black formatting locally on the codebase.
PenguinBoi12
requested changes
Apr 15, 2026
chrisdedman
commented
Apr 16, 2026
PenguinBoi12
requested changes
Apr 16, 2026
PenguinBoi12
requested changes
Apr 21, 2026
Collaborator
PenguinBoi12
left a comment
PenguinBoi12
left a comment
There was a problem hiding this comment.
In general it's good but everything related to the weather payload and error don't belong in the helper, it's meant to be a way to validate the data we receive in the service. That's why it's returned by the service.
However, the rest is fine.
chrisdedman
commented
May 11, 2026
PenguinBoi12
approved these changes
May 13, 2026
Collaborator
PenguinBoi12
left a comment
PenguinBoi12
left a comment
There was a problem hiding this comment.
LGTM! Well done, love it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.