⚡ Bolt: Optimize worktree bulk creation#98
Conversation
Moved `loadConfig()` call outside the `data.map` loop in `WorktreeService.create` to avoid O(N) disk reads when creating multiple worktrees. Updated `applyWorktreeCreateDefaults` to accept the pre-loaded configuration object. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored
applyWorktreeCreateDefaultsto accept a pre-loadedAgorConfiginstance instead of asynchronously callingloadConfig()internally. UpdatedWorktreeService.create()to resolve the configuration once before mapping over incoming worktree items.🎯 Why: In a bulk creation payload (
Array.isArray(data)),applyWorktreeCreateDefaultswas being called for each element inside aPromise.all. SinceloadConfig()parses the config file from disk each time, this caused an O(N) disk I/O bottleneck that severely impacted performance on large imports or batched creations.📊 Impact: Converts O(N) disk operations per request into an O(1) operation, heavily speeding up bulk worktree imports/creations.
🔬 Measurement: Verified that tests still pass, specifically
src/services/worktrees.test.ts. This confirms that worktrees apply the same system configurations as before.PR created automatically by Jules for task 294337104724161961 started by @Donach