Skip to content

⚡ Bolt: hoist loadConfig out of bulk worktree creation loop#96

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt/worktree-creation-disk-io-fix-5720922110204555043
Open

⚡ Bolt: hoist loadConfig out of bulk worktree creation loop#96
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt/worktree-creation-disk-io-fix-5720922110204555043

Conversation

@Donach

@Donach Donach commented Jun 20, 2026

Copy link
Copy Markdown

💡 What: Refactored applyWorktreeCreateDefaults in apps/agor-daemon/src/services/worktrees.ts to accept the pre-loaded AgorConfig instead of calling loadConfig() internally. Updated the create method to invoke loadConfig() exactly once prior to mapping through the worktree data array.
🎯 Why: loadConfig() involves a synchronous read of the ~/.agor/config.yaml file from the disk. When executing a bulk insert of N worktrees, this previously triggered N distinct file reads, leading to severe latency bottlenecks and an O(N) penalty.
📊 Impact: Reduces disk read operations from N to exactly 1 during bulk worktree creation, significantly accelerating the response time and overall latency for operations spawning numerous worktrees.
🔬 Measurement: Verify the improvement by running a bulk worktree creation request and observing latency differences, or examining filesystem strace output during the function call. Tests in @agor/daemon correctly pass with no regressions.


PR created automatically by Jules for task 5720922110204555043 started by @Donach

Resolves O(N) disk I/O operations occurring during bulk worktree creation by hoisting `loadConfig()` out of the mapped loop inside the `create` method. It loads the config once and passes it via parameters to `applyWorktreeCreateDefaults`.

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant