⚡ Bolt: hoist loadConfig out of bulk worktree creation loop#96
Conversation
Resolves O(N) disk I/O operations occurring during bulk worktree creation by hoisting `loadConfig()` out of the mapped loop inside the `create` method. It loads the config once and passes it via parameters to `applyWorktreeCreateDefaults`. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored
applyWorktreeCreateDefaultsinapps/agor-daemon/src/services/worktrees.tsto accept the pre-loadedAgorConfiginstead of callingloadConfig()internally. Updated thecreatemethod to invokeloadConfig()exactly once prior to mapping through the worktree data array.🎯 Why:
loadConfig()involves a synchronous read of the~/.agor/config.yamlfile from the disk. When executing a bulk insert ofNworktrees, this previously triggeredNdistinct file reads, leading to severe latency bottlenecks and an O(N) penalty.📊 Impact: Reduces disk read operations from
Nto exactly1during bulk worktree creation, significantly accelerating the response time and overall latency for operations spawning numerous worktrees.🔬 Measurement: Verify the improvement by running a bulk worktree creation request and observing latency differences, or examining filesystem strace output during the function call. Tests in
@agor/daemoncorrectly pass with no regressions.PR created automatically by Jules for task 5720922110204555043 started by @Donach