⚡ Bolt: Batch MCP OAuth token queries#115
Conversation
💡 What: Replaced individual `getToken()` database queries in the FeathersJS `injectPerUserOAuthTokens` hook loop with a batched `getTokensForServers` repository method using Drizzle's `inArray()`. 🎯 Why: Resolves a critical N+1 database querying bottleneck. Previously, fetching a list of MCP servers would trigger a separate database query to check for OAuth tokens for each individual server in the `Promise.all` loop. 📊 Impact: Reduces database queries from O(N) to O(1) when loading the list of available MCP servers, significantly decreasing latency. 🔬 Measurement: Verify by executing `pnpm test` and observing reduced DB query logs when listing MCP servers. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced individual
getToken()database queries in the FeathersJSinjectPerUserOAuthTokenshook loop with a batchedgetTokensForServersrepository method using Drizzle'sinArray().🎯 Why: Resolves a critical N+1 database querying bottleneck. Previously, fetching a list of MCP servers would trigger a separate database query to check for OAuth tokens for each individual server in the
Promise.allloop.📊 Impact: Reduces database queries from O(N) to O(1) when loading the list of available MCP servers, significantly decreasing latency.
🔬 Measurement: Verify by executing
pnpm testand observing reduced DB query logs when listing MCP servers.PR created automatically by Jules for task 678044046388183982 started by @Donach