⚡ Bolt: Batch OAuth token fetches for MCP servers#113
Conversation
- Added `getTokensForServers` to `UserMCPOAuthTokenRepository` to fetch tokens for multiple servers in a single query using `inArray`. - Refactored `injectPerUserOAuthTokens` in `register-hooks.ts` to pre-fetch all needed tokens and map them in memory by a composite key (serverId:userId/mode) to resolve an N+1 query bottleneck. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Batches the retrieval of OAuth tokens for MCP servers by querying
user_mcp_oauth_tokensin a single query usinginArray.🎯 Why: To fix an N+1 database query problem where the Feathers hook was sequentially calling
getToken()inside aPromise.allloop when enumerating MCP servers.📊 Impact: Reduces database latency during MCP server listings (e.g.
GET /mcp-servers). Instead ofNsequential/parallel database queries forNservers, it only issues 1 query.🔬 Measurement: Verify by executing
pnpm --filter @agor/daemon testto ensure tokens continue to be injected correctly into the MCP server objects.PR created automatically by Jules for task 2154695153671090735 started by @Donach