Skip to content

🛡️ Sentinel: [CRITICAL] Fix SQL injection in jsonExtract using sql.raw#110

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
fix/sentinel-jsonextract-sqli-3033738078864178928
Open

🛡️ Sentinel: [CRITICAL] Fix SQL injection in jsonExtract using sql.raw#110
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
fix/sentinel-jsonextract-sqli-3033738078864178928

Conversation

@Donach

@Donach Donach commented Jun 29, 2026

Copy link
Copy Markdown

Sentinel has identified a potential SQL injection vulnerability in packages/core/src/db/database-wrapper.ts.

When resolving PostgreSQL JSON paths in jsonExtract, the code previously relied on sql.raw string interpolation, which bypasses Drizzle's parameterization and exposes the application to SQL injection if any of the JSON path keys were dynamically generated or supplied from an untrusted source.

This PR fixes the vulnerability by using Drizzle ORM's parameterized template literals and explicitly casting the bound parameters to ::text so that the overloaded PostgreSQL JSON operators (-> and ->>) resolve correctly without sql.raw.

Also appended this learning to the .jules/sentinel.md journal.


PR created automatically by Jules for task 3033738078864178928 started by @Donach

Replaces the vulnerable \`sql.raw\` block in the PostgreSQL jsonExtract builder with parameterized SQL blocks bound to \`::text\` casts, preventing dynamic JSON keys from being exposed to SQL injection.

Also adds this finding to the Sentinel journal for future prevention.

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant