Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in Unix user lookups#104

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel/fix-command-injection-8025371133038674867
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in Unix user lookups#104
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel/fix-command-injection-8025371133038674867

Conversation

@Donach

@Donach Donach commented Jun 24, 2026

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command injection in getGidFromGroupName, getUidFromUsername, getHomedirFromUsername, and unixUserExists.
🎯 Impact: Attackers could potentially execute arbitrary shell commands if they can control the username or groupName parameters passed to these functions.
πŸ”§ Fix: Replaced execSync with execFileSync to bypass shell execution, used argument arrays, and utilized the -- double-dash to prevent argument injection.
βœ… Verification: Ran pnpm -w run lint:fix and pnpm --filter @agor/core test. Tests pass and no new issues are introduced.


PR created automatically by Jules for task 8025371133038674867 started by @Donach

Replaced vulnerable `execSync` calls with `execFileSync` in `packages/core/src/unix/id-lookups.ts` and `packages/core/src/unix/user-manager.ts` to prevent command injection vulnerabilities where a user or group name could include shell escape characters. Tests were updated to reflect this change.

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant