⚡ Bolt: Cache loadConfig during bulk worktree creations#101
Conversation
This commit addresses a performance bottleneck in `apps/agor-daemon/src/services/worktrees.ts`. During bulk worktree creation, `loadConfig()` was being called inside a `Promise.all` loop for every item. Because `loadConfig()` performs synchronous disk I/O, this resulted in an O(N) I/O bottleneck. The optimization hoists `loadConfig()` outside the loop. It is loaded exactly once and passed as an argument to the configuration handler, achieving O(1) disk I/O. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Hoisted the
loadConfig()call outside the bulk creation loop in theWorktreesServiceand passed theAgorConfigto the helper function.🎯 Why: To eliminate an O(N) disk I/O performance bottleneck where the configuration was being parsed from disk on every iteration of a bulk operation.
📊 Impact: Reduces file system operations to O(1) during bulk worktree creations. This will significantly decrease latency when initializing many worktrees at once.
🔬 Measurement: Verify by running
pnpm --filter @agor/daemon testto ensureWorktreesServicecreation flows behave exactly as before but with improved theoretical performance over large data sets.PR created automatically by Jules for task 8690505536526889028 started by @Donach