Skip to content

Update VERSION for 0.10.0-rc2 #2951

Merged
chernser merged 4 commits into
v0.10.0from
pre_0.10.0-rc2
Jul 22, 2026
Merged

Update VERSION for 0.10.0-rc2 #2951
chernser merged 4 commits into
v0.10.0from
pre_0.10.0-rc2

Conversation

@chernser

@chernser chernser commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updated VERSION prior to release
  • Added new keywords and table engines.

@chernser
chernser marked this pull request as ready for review July 22, 2026 17:09
@chernser
chernser requested a review from mzitnik as a code owner July 22, 2026 17:09
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Triage

Category: infraRisk: medium

Summary
This PR bumps the project version from 0.10.0-rc1 to 0.10.0-rc2 across VERSION, root pom.xml, all example pom.xml/gradle.properties files, and the performance/ module. However, the PR quietly bundles two behavioral source changes in jdbc-v2: (1) four new SQL keyword aliases (ANALYZE, AT, MANIFEST, RESERVATION) added to ClickHouseSqlUtils.java's parser allowlist, and (2) three new engine-to-table-type mappings (QueryRunner, Remote, RemoteSecure) added to DatabaseMetaDataImpl.java. The PR body only says "Updated VERSION prior to release" with no mention of these changes and no linked issue.

What this impacts

  • VERSION, root pom.xml, all examples/*/pom.xml, examples/*/gradle.properties, performance/pom.xml — version string update only
  • jdbc-v2/src/main/java/.../parser/javacc/ClickHouseSqlUtils.java — SQL parser keyword allowlist (behavioral change: queries using these keywords as identifiers will now parse correctly)
  • jdbc-v2/src/main/java/.../metadata/DatabaseMetaDataImpl.java — JDBC DatabaseMetaData engine type mapping (behavioral change: getTables() will now correctly classify Remote-family engines)

Concerns

  • Intent drift / bundled changes: The PR title and body frame this as a pure version bump (infra), but it includes behavioral source changes in jdbc-v2. These have no linked issue, no description in the PR body, and no apparent regression tests. Medium rule fires: "Behavioral change in a single hot-path module (jdbc-v2)."
  • No linked issue for source changes: The keyword alias additions and engine-type mappings are non-trivial fixes with no explanation of what user-facing bugs they address, making them hard to verify for correctness or completeness.

Required reviewer action

  • At least one human reviewer should verify the two jdbc-v2 source changes are intentional, correct, and complete — ideally with a brief explanation or linked issue added to the PR body before merge.

@chernser
chernser merged commit c811085 into v0.10.0 Jul 22, 2026
37 of 41 checks passed
@chernser
chernser deleted the pre_0.10.0-rc2 branch July 22, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants