fix(clickhouse-client): load services from client module#2941
Open
014-code wants to merge 1 commit into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 1f56b10. Configure here.
Load ClickHouseRequestManager and ClickHouseDnsResolver providers from the com.clickhouse.client module instead of delegating through ClickHouseUtils in com.clickhouse.data. This keeps JPMS ServiceLoader uses checks aligned with the module that owns the service types. Add the missing ClickHouseRequestManager uses directives to the Java 9 and Java 11 module descriptors and cover the fallback/module descriptor contract in ClickHouseClientTest. Fixes ClickHouse#2669
014-code
force-pushed
the
fix/2669-jpms-service-loader
branch
from
July 21, 2026 12:07
1f56b10 to
fd2cf5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix JPMS/module-path service loading for
ClickHouseRequestManager.Fixes #2669.
Problem
When applications run ClickHouse Java modules on the module path, loading
ClickHouseRequestManagercan fail with:java.util.ServiceConfigurationError: com.clickhouse.client.ClickHouseRequestManager: module com.clickhouse.data does not declare usesThe failure happens because
ClickHouseRequestManagerwas loaded throughClickHouseUtils.getService(...), so the actualServiceLoader.load(...)caller was in the
com.clickhouse.datamodule.com.clickhouse.datacannotdeclare
uses com.clickhouse.client.ClickHouseRequestManagerwithout creatinga reverse dependency on
com.clickhouse.client.Changes
ClickHouseRequestManagerproviders directly from thecom.clickhouse.clientmodule.ClickHouseDnsResolverproviders directly from thecom.clickhouse.clientmodule for the same JPMS reason.uses com.clickhouse.client.ClickHouseRequestManagerto the Java 9 andJava 11 module descriptors.
contract.
CHANGELOG.md.Compatibility
No public API changes.
Default behavior is preserved: when no custom provider is found, the client
falls back to the built-in
ClickHouseRequestManagerandClickHouseDnsResolverimplementations. The change only moves service loading to the module that owns
and declares the service types.
Testing
git diff --checkmvn -t C:\tmp\clickhouse-java-toolchains.xml -Dj8 -pl clickhouse-client -am -Dtest=com.clickhouse.client.ClickHouseClientTest -Dsurefire.failIfNoSpecifiedTests=false test