Add names to ColumnTupleT<...> strong type#509
Open
IyeOnline wants to merge 1 commit into
Open
Conversation
This adds field names to the `ColumnTupleT<...>` strong type wrapper. Previously only the erased ColumnTuple supported field names, which meant that `ColumnTupleT<...>::Wrap(ColumnTuple&&)` would drop the field names and there was no way to create the strong type with column names in the first place. - Fixes ClickHouse#507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds field names to the
ColumnTupleT<...>strong type wrapper.Previously only the erased ColumnTuple supported field names, which meant
that
ColumnTupleT<...>::Wrap(ColumnTuple&&)would drop the field namesand there was no way to create the strong type with column names in the
first place.