feat(Text): add noWrap prop for white-space control - #1094
Open
gjones wants to merge 6 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@hoorayimhelping This was your request, does this fulfil your expectations? |
Co-authored-by: Cursor <cursoragent@cursor.com>
hoorayimhelping
approved these changes
Jun 24, 2026
hoorayimhelping
left a comment
hoorayimhelping
left a comment
Member
There was a problem hiding this comment.
Easily the best code I've ever seen
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-lfdwmxe54-clickhouse.vercel.app Built from commit: |
XOP
requested changes
Jul 29, 2026
| /** Whether the text should fill the full width of its container */ | ||
| fillWidth?: boolean; | ||
| /** Whether the text should stay on a single line */ | ||
| noWrap?: boolean; |
Collaborator
There was a problem hiding this comment.
I see where the need for the change is coming from,
but there are a couple of things to consider:
- nowrap for the sake of nowrap is called sparingly, the top usage is to set the truncation (ellipsis or not)
- using boolean prop is not advised, as it limits the API of the component on one hand and on the other spawns other similar props
Proposal: change to
overflowMode?: 'wrap' (default) | 'nowrap' | 'ellipsis' | 'truncate' | 'break-word'
this prop can be consistently used in components featuring text that might need adjustments, i.e. tooltip or badge.
as the scope of PR would grow I would suggest to add only wrap and nowrap for now.
note: separately we'll need to address the truncation components to avoid duplicated patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Adds a noWrap prop to the
Textcomponent. I opted for a boolean to keep things as simple as possible until we get more requests for things likepre,prewrapetc etc.Tickets?
#853