New. Catch fetch request. Iframe forms of sender.com protected.#829
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #829 +/- ##
============================================
- Coverage 27.67% 27.55% -0.12%
+ Complexity 5878 5824 -54
============================================
Files 283 282 -1
Lines 24833 24711 -122
============================================
- Hits 6872 6810 -62
+ Misses 17961 17901 -60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR extends the front-end fetch() interception in the CleanTalk public handler to support additional third‑party embedded form providers (specifically sender.com iframe forms), while refactoring the existing Bitrix24 logic into a shared, config-driven external-form handler flow.
Changes:
- Added shared external-form check helpers (
collectFormFields,runExternalFormCheck) and a provider registry (externalFormHandlers) to centralize Bitrix24 + sender.com handling. - Replaced the old inline Bitrix24-specific block with
processFetchOfExternalForms()to support multiple providers consistently. - Updated committed build artifacts (prebuild bundles + admin settings minified assets).
Reviewed changes
Copilot reviewed 9 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| js/src/public-1-main.js | Refactors external-form fetch interception and adds sender.com iframe form support via a handler registry. |
| js/prebuild/apbct-public-bundle.js | Mirrors the new external-form handler registry in the prebuild bundle. |
| js/prebuild/apbct-public-bundle_int-protection.js | Mirrors the new external-form handler registry in the int-protection prebuild bundle. |
| js/prebuild/apbct-public-bundle_int-protection_gathering.js | Mirrors the new external-form handler registry in the int-protection+gathering prebuild bundle. |
| js/prebuild/apbct-public-bundle_gathering.js | Mirrors the new external-form handler registry in the gathering prebuild bundle. |
| js/prebuild/apbct-public-bundle_full-protection.js | Mirrors the new external-form handler registry in the full-protection prebuild bundle. |
| js/prebuild/apbct-public-bundle_full-protection_gathering.js | Mirrors the new external-form handler registry in the full-protection+gathering prebuild bundle. |
| js/prebuild/apbct-public-bundle_ext-protection.js | Mirrors the new external-form handler registry in the ext-protection prebuild bundle. |
| js/prebuild/apbct-public-bundle_ext-protection_gathering.js | Mirrors the new external-form handler registry in the ext-protection+gathering prebuild bundle. |
| js/cleantalk-admin-settings-page.min.js.map | Updates admin settings sourcemap artifact. |
| js/cleantalk-admin-settings-page.min.js | Updates admin settings minified artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # js/apbct-public-bundle.min.js # js/apbct-public-bundle_ext-protection.min.js # js/apbct-public-bundle_ext-protection_gathering.min.js # js/apbct-public-bundle_full-protection.min.js # js/apbct-public-bundle_full-protection_gathering.min.js # js/apbct-public-bundle_gathering.min.js # js/apbct-public-bundle_int-protection.min.js # js/apbct-public-bundle_int-protection_gathering.min.js
https://app.doboard.com/1/task/35990