Code.Content-Type header#688
Open
alexander-b-clean wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds centralized Content-Type handling for Remote Call responses in the CleantalkSP\SpbctWP\RemoteCalls layer, plus a PHPUnit test to validate the action→Content-Type mapping.
Changes:
- Introduces a default response
Content-Typeconstant and an action→Content-Typelookup table. - Sends a
Content-Typeheader during remote call initialization based onspbc_remote_call_action. - Adds a PHPUnit test suite covering the resolver behavior for known actions and fallbacks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lib/CleantalkSP/SpbctWP/RemoteCalls.php | Adds content-type constants/mapping, resolver, and header emission in the RC constructor. |
| tests/lib/CleantalkSP/SpbctWP/RemoteCalls/RemoteCallsContentTypeTest.php | Adds unit tests validating content-type resolution for several remote-call actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+67
to
+76
| /** | ||
| * Resolve the full Content-Type header value for action. | ||
| * | ||
| * @param string $action | ||
| * @return string | ||
| */ | ||
| public static function resolveContentType($action) | ||
| { | ||
| $action = strtolower((string)$action); | ||
|
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…tent-type-header.ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/36489