Fix security logs av#661
Open
AntonV1211 wants to merge 22 commits into
Open
Conversation
…irewall into security-logs.ab
AntonV1211
commented
May 19, 2026
AntonV1211
commented
May 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Security Log “User activity timeline” to support a “Most Active Users” view and adds a user-based filter that propagates from the timeline selection into the Security Logs list table (pagination/sort).
Changes:
- Added server-side handling to apply a
usersfilter to list-table SQL args for AJAX pagination/sort/switch. - Enhanced timeline widget UX: “Most Active Users” option, richer user labels (role + event count), and click-to-filter behavior that updates URL query params.
- Updated table pagination JS to include the
usersfilter in AJAX requests and added an explicitupdateSecurityLogTable()helper.
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/CleantalkSP/SpbctWP/ListTable.php | Adds applyUserFilter() and applies it to AJAX table handlers. |
| js/src/spbc-timeline-widget.js | Adds “Most Active Users” view and URL-param-driven filtering behavior. |
| js/src/spbc-table.js | Refactors pagination listeners and propagates users filter into pagination requests; adds updateSecurityLogTable(). |
| inc/spbc-tools.php | Extends timeline data payload to include user roles and adjusts timestamp offset handling. |
| inc/spbc-admin.php | Removes registration for wp_ajax_spbc_tbl-switch. |
| js/spbc-timeline-widget.min.js | Built/minified output update for timeline widget. |
| js/spbc-timeline-widget.min.js.map | Source map update for timeline widget. |
| js/spbc-table.min.js | Built/minified output update for table script. |
| js/spbc-table.min.js.map | Source map update for table script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glomberg
approved these changes
May 20, 2026
…ser list, edits from the test
…ost Active Users chart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/48852#comment_314652