Skip to content

fix: make check-format portable on Windows#2286

Closed
SyntaxSawdust wants to merge 1 commit into
ChromeDevTools:mainfrom
SyntaxSawdust:codex/fix-check-format-windows
Closed

fix: make check-format portable on Windows#2286
SyntaxSawdust wants to merge 1 commit into
ChromeDevTools:mainfrom
SyntaxSawdust:codex/fix-check-format-windows

Conversation

@SyntaxSawdust

Copy link
Copy Markdown

Summary

  • Remove the trailing semicolon from the check-format npm script.

Why

  • Two upstream PR validation notes (#2212, #2250) report that
    npm run check-format passes ESLint and Prettier on Windows, then exits
    non-zero because the script's trailing .; is parsed as an extra Prettier
    path.
  • Upstream package.json still contained the trailing semicolon. This keeps the
    same ESLint/Prettier checks and removes only the shell-sensitive terminator.

Tests

  • npm ci (passed; npm reported 17 moderate audit findings unrelated to this
    dependency-free diff)
  • npm run check-format (passed)
  • git diff --check (passed)
  • npm run build (fails with an unrelated TypeScript declaration conflict in
    node_modules/chrome-devtools-frontend/front_end/models/trace/ModelImpl.ts:230)

Scope / non-goals

  • Scope: package.json script cleanup only.
  • Non-goals: no lint/format toolchain changes, dependency changes, generated
    file updates, or issue creation.

Caveats

  • No dedicated issue exists; this references the PR validation notes as evidence
    rather than closing an issue.
  • Windows-specific behavior was not reproduced locally on this macOS checkout;
    the premise comes from the linked upstream validation notes.
  • Broader npm run build currently fails in an unrelated dependency TypeScript
    declaration.

@google-cla

google-cla Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant