chore: rename misspelled functions, remove duplicate import and dead code#2277
Open
fix2015 wants to merge 1 commit into
Open
chore: rename misspelled functions, remove duplicate import and dead code#2277fix2015 wants to merge 1 commit into
fix2015 wants to merge 1 commit into
Conversation
a handful of identifier typos in NetworkFormatter.ts: - formatHeadlers → formatHeaders - converNetworkRequestDetailedToStringDetailed → convertNetworkRequest... - responseAsTest → responseAsText also: - navigationStated → navigationStarted in WaitForHelper.ts - doubled "for for" → "for" in a PageCollector log message - removed duplicate import of node:fs/promises in McpContext.ts - removed dead if (!navigations) guard that could never trigger since navigations was already defaulted to [] via ??
OrKoN
changed the title
| } | ||
| override splitAfterNavigation(page: Page) { | ||
| const navigations = this.storage.get(page) ?? []; | ||
| if (!navigations) { |
Collaborator
There was a problem hiding this comment.
I think this should not be removed but rather then ?? [] should be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a handful of identifier typos in NetworkFormatter.ts while reading through the network capture code:
Also fixed a few other small things: