docs: conclude 2026-05-29 session — MASTERPLAN, RFAI status, failure ledger, ADRs

[Chris0Jeky]

Concludes the 2026-05-29 continuous-cycle session by recording it in the canonical docs (STATUS.md was already updated in #1119).

Changes

• docs/IMPLEMENTATION_MASTERPLAN.md — new "Current Cycle Outcome" entry for the 18-PR wave (RFAI complete, composable/identity-authz hardening, dependency wave + ignore rules, a11y/housekeeping); Last Updated → 2026-05-29.
• docs/ISSUE_EXECUTION_GUIDE.md — RFAI-10/11/12 marked delivered; RFAI roadmap noted complete (12/12, RFAI-01: Safety invariants, IA cut, eval seed, and recertification #973–RFAI-12: Learning loop UI, provenance drawer, Ollama flag, and beta gate #984).
• docs/agentic/FAILURE_LEDGER.md — logged the recurring failures + workarounds: EF Core 8/9 dependabot split (resolved via ignore rule), FluentAssertions v8 re-proposal (resolved), E2E Smoke board-restore flake (investigate-then-rerun), and the stacked-PR --delete-branch auto-close gotcha (retarget/rebase first).
• docs/decisions/ — ADR-0033 ratified Accepted (RFAI-11 RFAI-11: Ambient channel hardening — VS Code extension + voice prototype #1079 shipped the VS Code extension); new ADR-0034 documents the dependency version-cap policy (EF Core 8.x + FluentAssertions 7.x via dependabot ignore rules, incl. the v8 licensing rationale); INDEX updated.

Verification

• node scripts/check-docs-governance.mjs → passed.
• ADR files (34) match INDEX rows (34); ADR-0034 present.

Docs-only; no code change.

[Chris0Jeky]

Adversarial Review 1 of 2 (self) — PR #1121

Docs-only; review = factual accuracy + internal consistency. Cross-checked:

• MASTERPLAN entry: RFAI-11 = RFAI-11: Ambient channel hardening decision and prototype #983/RFAI-11: Ambient channel hardening — VS Code extension + voice prototype #1079, RFAI-12 = RFAI-12: Learning loop UI, provenance drawer, Ollama flag, and beta gate #984/RFAI-12: Learning loop UI, Ollama provider, ProvenanceDrawer, cohort dashboard #1080 ✓; all cited PRs (deps(nuget): FluentAssertions 6→7.2.2 (free line) across test projects #1088/Housekeeping: stale cleanup, STATUS.md update, tsconfig noEmit fix #1092/Fix unhandled promise rejections in frontend composables #1095/Add aria-labels to filter clear buttons in FilterPanel #1098/deps(nuget): Bump the dotnet-minor-patch group with 15 updates #1101/deps(nuget): Bump coverlet.collector and 13 others #1102/Fix composable cleanup leaks in useReviewProposals, useGlobalSearch, usePaperReviewSelectors #1104/deps(npm): bump the npm-minor-patch group across 1 directory with 23 updates #1105/FE: Use stable v-for keys instead of array index in static lists #1107/FE: Use stable v-for keys instead of array index in static lists #1108/BE: Two controllers bypass AuthenticatedControllerBase identity seam #1109/BE: Add Architecture.Tests guards for controller auth + standardize board-auth placement #1110/BE: Migrate Telemetry + EgressDisclosure controllers onto AuthenticatedControllerBase #1111/chore: ignore EF Core major bumps in dependabot (stop recurring 8/9 split) #1112/deps(nuget): Bump the dotnet-minor-patch group with 3 updates #1115/BE: Architecture guard for per-action authorization + explicit AllowAnonymous #1116/chore: ignore FluentAssertions major bumps in dependabot (stay on free 7.x) #1118/docs: STATUS.md sweep for 2026-05-29 continuous-cycle wave #1119/FE: Add aria-hidden to decorative SVG icons (#1099) #1120) and closed PRs (deps(npm): bump the npm-minor-patch group across 1 directory with 22 updates #1100/deps(nuget): Bump coverlet.collector and 14 others #1106/deps(nuget): Bump Microsoft.EntityFrameworkCore and StackExchange.Redis #1113/deps(nuget): Bump FluentAssertions from 7.2.2 to 8.10.0 #1117) match the session's actual merges/closures; Last Updated → 2026-05-29.
• ISSUE_EXECUTION_GUIDE: RFAI-10=RFAI-10: PWA share-target quick capture with offline queue #1078, RFAI-11=RFAI-11: Ambient channel hardening — VS Code extension + voice prototype #1079, RFAI-12=RFAI-12: Learning loop UI, Ollama provider, ProvenanceDrawer, cohort dashboard #1080 — all merged; roadmap 12/12 (RFAI-01: Safety invariants, IA cut, eval seed, and recertification #973–RFAI-12: Learning loop UI, provenance drawer, Ollama flag, and beta gate #984), consistent with the closed issues.
• FAILURE_LEDGER: the 4 entries reflect real events this session (EF 8/9 split deps(nuget): Bump coverlet.collector and 13 others #1102/deps(nuget): Bump coverlet.collector and 14 others #1106→chore: ignore EF Core major bumps in dependabot (stop recurring 8/9 split) #1112; FA v8 deps(nuget): Bump FluentAssertions from 7.2.2 to 8.10.0 #1117→chore: ignore FluentAssertions major bumps in dependabot (stay on free 7.x) #1118; E2E flake multi-board.spec.ts:197; stacked-PR close Fix composable cleanup leaks in useReviewProposals and useGlobalSearch #1096→Fix composable cleanup leaks in useReviewProposals, useGlobalSearch, usePaperReviewSelectors #1104).
• ADRs: ADR-0033 → Accepted (RFAI-11 RFAI-11: Ambient channel hardening — VS Code extension + voice prototype #1079 shipped it); ADR-0034 created + added to INDEX; ADR file count (34) == INDEX rows (34); references accurate.
• node scripts/check-docs-governance.mjs passes.

Verdict: No blocking issues. Independent fact-check in progress.

[gemini-code-assist]

Code Review

This pull request updates the project documentation to reflect the completion of the RFAI roadmap and details recent hardening and dependency updates. Specifically, it introduces ADR-0034, which establishes dependency version caps for Entity Framework Core (8.x) and FluentAssertions (7.x) to prevent recurring major-version update churn. The reviewer suggests using a wildcard pattern for Microsoft.EntityFrameworkCore.* and capping the design-time tools package (Microsoft.EntityFrameworkCore.Tools) alongside the runtime packages to ensure toolset compatibility and avoid design-time errors.

[gemini-code-assist]

Using a wildcard pattern like Microsoft.EntityFrameworkCore.* in .github/dependabot.yml is more robust as it automatically covers all EF Core ecosystem packages (such as .Relational or test-specific providers) and prevents partial upgrades that could reintroduce version splits.

Additionally, keeping Microsoft.EntityFrameworkCore.Tools on a different major version (10.x) than the runtime packages (8.x) and Microsoft.EntityFrameworkCore.Design (8.x) is generally discouraged. Mismatched design-time tools can cause errors during migration generation or database updates. Capping the tools package alongside the rest of the EF Core stack ensures complete toolset compatibility.

Suggested change

	- `Microsoft.EntityFrameworkCore`, `Microsoft.EntityFrameworkCore.Sqlite`,
	`Microsoft.EntityFrameworkCore.Design` — stay on 8.x until the runtime EF stack is
	migrated together in one deliberate PR. `Microsoft.EntityFrameworkCore.Tools` is a
	design-time-only package (`PrivateAssets`) tracked separately on its 10.x line and is
	intentionally **not** capped (it does not affect the runtime compile).
	- All Microsoft.EntityFrameworkCore.* packages (including .Sqlite, .Design, and .Tools via a wildcard pattern) — stay on 8.x until the runtime EF stack is migrated together in one deliberate PR. Capping the tools package alongside the runtime and design packages ensures toolset compatibility and prevents design-time errors during migration generation.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0588e2504e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Align the merged-PR count with STATUS

This new cycle summary records "18 PRs merged", but the same commit leaves docs/STATUS.md (the documented source of truth) saying "17 PRs merged" for the same 2026-05-29 wave. Agents use these canonical docs for handoff and planning, so this reintroduces docs drift immediately after noting that STATUS had been reconciled; please update STATUS in the same conclusion change or make the Masterplan count match it.

Useful? React with 👍 / 👎.

[Copilot]

Pull request overview

Docs-only session wrap-up for the 2026-05-29 continuous-cycle wave, updating roadmap, execution, failure-ledger, and ADR records to reflect completed RFAI work and dependency-cap decisions.

Changes:

• Marks RFAI-10/11/12 and the overall RFAI roadmap as delivered.
• Adds a 2026-05-29 masterplan cycle outcome and new failure-ledger entries.
• Ratifies ADR-0033 and adds ADR-0034 for dependency version caps.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
docs/ISSUE_EXECUTION_GUIDE.md	Updates RFAI roadmap issue statuses to delivered.
docs/IMPLEMENTATION_MASTERPLAN.md	Adds latest cycle outcome and updates the document date.
docs/agentic/FAILURE_LEDGER.md	Records recurring CI/dependency/worktree failure patterns and mitigations.
docs/decisions/INDEX.md	Updates ADR-0033 status and indexes ADR-0034.
docs/decisions/ADR-0033-ambient-channel-vscode-over-voice.md	Ratifies the ambient channel decision as accepted.
docs/decisions/ADR-0034-dependency-version-caps.md	Documents EF Core and FluentAssertions major-version cap policy.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Chris0Jeky]

Adversarial Review 2 of 2 (independent) + Fix Evidence

Independent fact-check verified every PR/issue citation, both ADRs, the FAILURE_LEDGER entries, the identity/authz claims, and scripts/check-docs-governance.mjs (passed). One LOW inconsistency found:

PR-count mismatch (fixed). MASTERPLAN said "18 PRs" while the already-merged STATUS.md said "17"; the authoritative gh pr list --search merged:2026-05-29 count is 19 (#1079, #1080, #1088, #1092, #1095, #1098, #1101, #1102, #1103, #1104, #1105, #1108, #1111, #1112, #1115, #1116, #1118, #1119, #1120).

• Fix: aligned both docs to 19 PRs — corrected the MASTERPLAN entry and (in this same PR) the merged STATUS.md headline. Docs governance re-run green.

All other content verified accurate (the reviewer specifically confirmed the stacked-PR ledger entry: #1095 merged 18:10:16 → #1096 auto-closed 18:10:19 → recovered as #1104). Both reviews complete; the one finding is addressed.