feat: migrate section: kube_pod_conditions_v1 - #44
Open
racicLuka wants to merge 1 commit into
Open
Conversation
racicLuka
force-pushed
the
CMK-36255-pod-conditions
branch
from
August 19, 2026 10:54
bd46434 to
a4dfdb5
Compare
Member
|
@racicLuka Let me know if this is ready for review, I see you requested but it's still in draft. |
racicLuka
marked this pull request as ready for review
August 20, 2026 06:59
Contributor
Author
|
You can review it and I will resolve the conflicts |
relrod
reviewed
Aug 20, 2026
racicLuka
force-pushed
the
CMK-36255-pod-conditions
branch
from
August 20, 2026 15:55
a4dfdb5 to
57b4a45
Compare
relrod
approved these changes
Aug 21, 2026
relrod
left a comment
relrod
left a comment
Member
There was a problem hiding this comment.
One inline comment, otherwise lgtm.
| if let Some(kube_start_time_v1) = KubeStartTimeV1::from_pod(self.api) { | ||
| out.push(WriteableSection::of(&me, &kube_start_time_v1)); | ||
| } | ||
| if let Some(kube_pod_conditions_v1) = &self.conditions() { |
Member
There was a problem hiding this comment.
Let's be consistent with the one above and just call KubePodConditionsV1::from_pod() directly here instead of having the intermediary step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMK-36255