Patched resolve_secret_option password_store API function to handle multiword arguments properly - #947
Open
lbuhleie wants to merge 1 commit into
Open
Conversation
…ultiword arguments properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General information
I encountered this issue when testing the new cmk.password_store.v1_unstable API that has been introduced with Checkmk 2.5.
Bugreport
When using the
parser_add_secret_optionandresolve_secret_optionfunctions from thenew cmk.password_store.v1_unstableAPI with theOPTION_NAMEvariable consisting of at least two words, separated by a '-' (e.g. 'client-secret'), the resolve function would break and throw a TypeError Exception. This happens because argparser translates such arguments to be separated by a '_' ("--client-secret" translates to args.client_secret).Proposed changes
I fixed this with this small one-liner that before anything else replaces "-" by "_" in the option_name variable. The change does not break any behaviour, only fixes this small issue.
I already did a Pull Request for this (#913), but some Pipelines failed and I lost track of it. So this is attempt #2 for this.