Skip to content

add vm_ip to labels of azure vms #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sehaeg wants to merge 3 commits into
base: master
Choose a base branch
from
+20 −0
Open

add vm_ip to labels of azure vms #945

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60ee3a6
add vm_ip to labels of azure vms
sehaeg Aug 14, 2026
c794df7
fix linter, typo
sehaeg Aug 17, 2026
6749602
dummy commit for pipeline
sehaeg Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/cmk-plugins/cmk/plugins/azure_v2/special_agent/agent_azure_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2368,6 +2368,22 @@ async def _collect_virtual_machines_resources(
key="value",
)

nics = await api_client.get_async(
"providers/Microsoft.Network/networkInterfaces",
params={"api-version": "2024-07-01"},
key="value",
)

vm_ip_map: dict[str, str] = {}
for nic in nics:
try:
vm_name = nic["properties"]["virtualMachine"]["id"].lower()

private_ip = nic["properties"]["ipConfigurations"][0]["properties"]["privateIPAddress"]
vm_ip_map[vm_name] = private_ip
except (KeyError, IndexError):
continue

virtual_machines: list[AzureResource] = []
for vm in response:
try:
Expand All @@ -2385,6 +2401,10 @@ async def _collect_virtual_machines_resources(
except KeyError:
raise ApiErrorMissingData("Virtual machine instance's statuses must be present")

vm_ip = vm_ip_map.get(vm["id"].lower())
if vm_ip is not None:
resource.labels["vm_ip"] = vm_ip

resource.info["specific_info"] = {"statuses": statuses}
# for backward compatibility
resource.labels["vm_instance"] = True
Expand Down
Loading